Re: [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Shankar, Uma
> -Original Message- > From: Jani Nikula > Sent: Thursday, April 16, 2020 3:43 PM > To: Gupta, Anshuman ; Shankar, Uma > > Cc: intel-gfx@lists.freedesktop.org; Vehmanen, Kai > Subject: Re: [v5] drm/i915/display: Enable DP Display Audio WA > > On Thu, 16 Apr 2020, Anshuman Gupta wrot

Re: [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Jani Nikula
On Thu, 16 Apr 2020, Anshuman Gupta wrote: > IMHO with control flow this function above initilization is not > required. > u may remove this initilization if u agree, while pushing the patch. I don't recommend anyone changing anything even remotely functional while pushing. I'm fine

Re: [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Anshuman Gupta
On 2020-04-16 at 13:17:21 +0530, Uma Shankar wrote: > For certain DP VDSC bpp settings, hblank asserts before hblank_early, > leading to a bad audio state. Driver need to program "hblank early > enable" and "samples per line" parameters in AUDIO_CONFIG_BE > register. > > This is Display Audio WA #

[Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA

2020-04-16 Thread Uma Shankar
For certain DP VDSC bpp settings, hblank asserts before hblank_early, leading to a bad audio state. Driver need to program "hblank early enable" and "samples per line" parameters in AUDIO_CONFIG_BE register. This is Display Audio WA #1406928334 for 4k+VDSC usecase applicable on DP encoders. Implem