Re: [Intel-gfx] [RFC v2 1/4] drm: Add support to find drm_panel by name

2015-01-16 Thread Thierry Reding
On Tue, Jan 13, 2015 at 12:08:11AM +0100, Daniel Vetter wrote: > On Fri, Jan 9, 2015 at 1:50 PM, Jani Nikula wrote: > > I have a slightly uneasy feeling about handing out drm_panel pointers > > (both from here and of_drm_find_panel) without refcounting. If the panel > > driver gets removed, whoeve

Re: [Intel-gfx] [RFC v2 1/4] drm: Add support to find drm_panel by name

2015-01-13 Thread Andrzej Hajda
On 01/13/2015 12:08 AM, Daniel Vetter wrote: > On Fri, Jan 9, 2015 at 1:50 PM, Jani Nikula wrote: >> I have a slightly uneasy feeling about handing out drm_panel pointers >> (both from here and of_drm_find_panel) without refcounting. If the panel >> driver gets removed, whoever called the find fun

Re: [Intel-gfx] [RFC v2 1/4] drm: Add support to find drm_panel by name

2015-01-12 Thread Daniel Vetter
On Fri, Jan 9, 2015 at 1:50 PM, Jani Nikula wrote: > I have a slightly uneasy feeling about handing out drm_panel pointers > (both from here and of_drm_find_panel) without refcounting. If the panel > driver gets removed, whoever called the find functions will have a > dangling pointer. I supposed

Re: [Intel-gfx] [RFC v2 1/4] drm: Add support to find drm_panel by name

2015-01-11 Thread Kumar, Shobhit
On 1/9/2015 6:20 PM, Jani Nikula wrote: On Fri, 02 Jan 2015, Shobhit Kumar wrote: For scenarios where OF is not available, we can use panel identification by name. Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/drm_panel.c | 18 ++ include/drm/drm_panel.h | 3 +++ 2

Re: [Intel-gfx] [RFC v2 1/4] drm: Add support to find drm_panel by name

2015-01-09 Thread Jani Nikula
On Fri, 02 Jan 2015, Shobhit Kumar wrote: > For scenarios where OF is not available, we can use panel identification by > name. > > Signed-off-by: Shobhit Kumar > --- > drivers/gpu/drm/drm_panel.c | 18 ++ > include/drm/drm_panel.h | 3 +++ > 2 files changed, 21 insertions(+

[Intel-gfx] [RFC v2 1/4] drm: Add support to find drm_panel by name

2015-01-02 Thread Shobhit Kumar
For scenarios where OF is not available, we can use panel identification by name. Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/drm_panel.c | 18 ++ include/drm/drm_panel.h | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/