Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-21 Thread Ville Syrjälä
On Fri, Nov 18, 2016 at 04:20:32PM +0200, Jani Nikula wrote: > The platform flags in device info are (mostly) mutually > exclusive. Replace the flags with an enum. Add the platform enum also > for platforms that previously didn't have a flag, and give them codename > logging in dmesg. > > Pineview

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-21 Thread Jani Nikula
On Mon, 21 Nov 2016, Tvrtko Ursulin wrote: > On 21/11/2016 09:27, Jani Nikula wrote: >> On Fri, 18 Nov 2016, Tvrtko Ursulin wrote: >>> On 18/11/2016 14:20, Jani Nikula wrote: The platform flags in device info are (mostly) mutually exclusive. Replace the flags with an enum. Add the platf

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-21 Thread Tvrtko Ursulin
On 21/11/2016 09:27, Jani Nikula wrote: On Fri, 18 Nov 2016, Tvrtko Ursulin wrote: On 18/11/2016 14:20, Jani Nikula wrote: The platform flags in device info are (mostly) mutually exclusive. Replace the flags with an enum. Add the platform enum also for platforms that previously didn't have a

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-21 Thread Jani Nikula
On Fri, 18 Nov 2016, Tvrtko Ursulin wrote: > On 18/11/2016 14:20, Jani Nikula wrote: >> The platform flags in device info are (mostly) mutually >> exclusive. Replace the flags with an enum. Add the platform enum also >> for platforms that previously didn't have a flag, and give them codename >> lo

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-18 Thread Tvrtko Ursulin
On 18/11/2016 14:20, Jani Nikula wrote: The platform flags in device info are (mostly) mutually exclusive. Replace the flags with an enum. Add the platform enum also for platforms that previously didn't have a flag, and give them codename logging in dmesg. It just saddens me a bit that it prev

Re: [Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 04:20:32PM +0200, Jani Nikula wrote: > The platform flags in device info are (mostly) mutually > exclusive. Replace the flags with an enum. Add the platform enum also > for platforms that previously didn't have a flag, and give them codename > logging in dmesg. > > Pineview

[Intel-gfx] [RFC PATCH] drm/i915: replace platform flags with a platform enum

2016-11-18 Thread Jani Nikula
The platform flags in device info are (mostly) mutually exclusive. Replace the flags with an enum. Add the platform enum also for platforms that previously didn't have a flag, and give them codename logging in dmesg. Pineview remains an exception, the platform being G33 for that. Signed-off-by: J