Re: [Intel-gfx] [RFC PATCH] drm/i915: move module parameters into a struct

2014-01-06 Thread Daniel Vetter
On Fri, Jan 03, 2014 at 02:19:51PM -0200, Paulo Zanoni wrote: > 2014/1/3 Jani Nikula : > > With 20+ module parameters I think referring to them via a struct > > improves clarity. The downsides are losing static on a couple of > > variables and not having the initialization and module_param_named()

Re: [Intel-gfx] [RFC PATCH] drm/i915: move module parameters into a struct

2014-01-03 Thread Paulo Zanoni
2014/1/3 Jani Nikula : > With 20+ module parameters I think referring to them via a struct > improves clarity. The downsides are losing static on a couple of > variables and not having the initialization and module_param_named() > right next to each other. On the other hand, all module parameters a

[Intel-gfx] [RFC PATCH] drm/i915: move module parameters into a struct

2014-01-03 Thread Jani Nikula
With 20+ module parameters I think referring to them via a struct improves clarity. The downsides are losing static on a couple of variables and not having the initialization and module_param_named() right next to each other. On the other hand, all module parameters are now defined in one place at