Re: [Intel-gfx] [RFC PATCH] drm/i915: add new intel audio file to group DP/HDMI audio

2014-09-18 Thread Daniel Vetter
On Thu, Sep 18, 2014 at 3:37 PM, Jani Nikula wrote: > On Thu, 18 Sep 2014, Daniel Vetter wrote: >> lgtm, but I think to make code extraction into new files really worth >> it this should be followed up with a small patch to add an overview >> DOC section and kerneldoc for the non-static functions

Re: [Intel-gfx] [RFC PATCH] drm/i915: add new intel audio file to group DP/HDMI audio

2014-09-18 Thread Jani Nikula
On Thu, 18 Sep 2014, Daniel Vetter wrote: > lgtm, but I think to make code extraction into new files really worth > it this should be followed up with a small patch to add an overview > DOC section and kerneldoc for the non-static functions. Plus pulling > it all in at a neat place into our driver

Re: [Intel-gfx] [RFC PATCH] drm/i915: add new intel audio file to group DP/HDMI audio

2014-09-18 Thread Daniel Vetter
lgtm, but I think to make code extraction into new files really worth it this should be followed up with a small patch to add an overview DOC section and kerneldoc for the non-static functions. Plus pulling it all in at a neat place into our driver docs. -Daniel On Wed, Sep 17, 2014 at 7:26 PM, Ja

Re: [Intel-gfx] [RFC PATCH] drm/i915: add new intel audio file to group DP/HDMI audio

2014-09-17 Thread Paulo Zanoni
2014-09-17 14:26 GMT-03:00 Jani Nikula : > No functional changes. http://patchwork.freedesktop.org/patch/24017/ But yeah, if you want to put more stuff there, intel_audio.c looks like a better name. > > Signed-off-by: Jani Nikula > > --- > > I was looking at the audio stuff in connection with s

[Intel-gfx] [RFC PATCH] drm/i915: add new intel audio file to group DP/HDMI audio

2014-09-17 Thread Jani Nikula
No functional changes. Signed-off-by: Jani Nikula --- I was looking at the audio stuff in connection with some bugs, and thought the eld functions could use some love. But before proceeding, I started wondering whether the audio functions would be better off in a file of their own for starters,