Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-31 Thread Lucas De Marchi
On Wed, Oct 31, 2018 at 10:13:43AM +0200, Jani Nikula wrote: > On Tue, 30 Oct 2018, Lucas De Marchi wrote: > > On Tue, Oct 30, 2018 at 11:52:30AM +0200, Jani Nikula wrote: > >> On Mon, 29 Oct 2018, Rodrigo Vivi wrote: > >> > +#define IS_DISPLAY_GEN2(dev_priv) > >> > (!!((dev_priv)->info.di

Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-31 Thread Jani Nikula
On Wed, 31 Oct 2018, Rodrigo Vivi wrote: > On Wed, Oct 31, 2018 at 11:00:54AM +0200, Jani Nikula wrote: >> On Wed, 31 Oct 2018, Tvrtko Ursulin wrote: >> > I saw some mention somewhere on IS_GEN_RANGE, which looked clearer than >> > IS_GEN(dev_priv, s, e). Presumably that did not go anywhere sinc

Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-31 Thread Rodrigo Vivi
On Wed, Oct 31, 2018 at 11:00:54AM +0200, Jani Nikula wrote: > On Wed, 31 Oct 2018, Tvrtko Ursulin wrote: > > I saw some mention somewhere on IS_GEN_RANGE, which looked clearer than > > IS_GEN(dev_priv, s, e). Presumably that did not go anywhere since now > > the proposal is the above? I have to

Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-31 Thread Jani Nikula
On Wed, 31 Oct 2018, Tvrtko Ursulin wrote: > I saw some mention somewhere on IS_GEN_RANGE, which looked clearer than > IS_GEN(dev_priv, s, e). Presumably that did not go anywhere since now > the proposal is the above? I have to say I am not sure it reads > completely intuitive when seen near in

Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-31 Thread Tvrtko Ursulin
On 31/10/2018 08:13, Jani Nikula wrote: On Tue, 30 Oct 2018, Lucas De Marchi wrote: On Tue, Oct 30, 2018 at 11:52:30AM +0200, Jani Nikula wrote: On Mon, 29 Oct 2018, Rodrigo Vivi wrote: +#define IS_DISPLAY_GEN2(dev_priv) (!!((dev_priv)->info.display_gen_mask \ +

Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-31 Thread Jani Nikula
On Tue, 30 Oct 2018, Lucas De Marchi wrote: > On Tue, Oct 30, 2018 at 11:52:30AM +0200, Jani Nikula wrote: >> On Mon, 29 Oct 2018, Rodrigo Vivi wrote: >> > +#define IS_DISPLAY_GEN2(dev_priv) (!!((dev_priv)->info.display_gen_mask \ >> > + & BIT(2))) >> > +#defi

Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-30 Thread Lucas De Marchi
On Tue, Oct 30, 2018 at 11:52:30AM +0200, Jani Nikula wrote: > On Mon, 29 Oct 2018, Rodrigo Vivi wrote: > > Introduce Display Gen. The goal is to use this to minimize > > the amount of platform codename checks we have nowdays on > > display code. > > > > The introduction of a new platform should b

Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-30 Thread Rodrigo Vivi
+cc Ville On Tue, Oct 30, 2018 at 11:52:30AM +0200, Jani Nikula wrote: > On Mon, 29 Oct 2018, Rodrigo Vivi wrote: > > Introduce Display Gen. The goal is to use this to minimize > > the amount of platform codename checks we have nowdays on > > display code. > > > > The introduction of a new platfo

Re: [Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-30 Thread Jani Nikula
On Mon, 29 Oct 2018, Rodrigo Vivi wrote: > Introduce Display Gen. The goal is to use this to minimize > the amount of platform codename checks we have nowdays on > display code. > > The introduction of a new platform should be just > gen >= current. So the patches 1-3 look nice for GLK. The thing

[Intel-gfx] [RFC 1/4] drm/i915: Add Display Gen info.

2018-10-29 Thread Rodrigo Vivi
Introduce Display Gen. The goal is to use this to minimize the amount of platform codename checks we have nowdays on display code. The introduction of a new platform should be just gen >= current. Just a gen++ without exposing any new feature or ip. so this would minimize the amount of patches ne