Re: [Intel-gfx] [RFC 03/15] drm/i915: Update sprite watermarks outside vblank evasion

2015-05-21 Thread Damien Lespiau
On Wed, May 20, 2015 at 07:12:15PM -0700, Matt Roper wrote: > We never removed the sprite watermark updates from our low-level > foo_update_plane() functions; since our hardware updates happen under > vblank evasion, we're not supposed to be calling potentially sleeping > functions there (since int

Re: [Intel-gfx] [RFC 03/15] drm/i915: Update sprite watermarks outside vblank evasion

2015-05-21 Thread Ville Syrjälä
On Wed, May 20, 2015 at 07:12:15PM -0700, Matt Roper wrote: > We never removed the sprite watermark updates from our low-level > foo_update_plane() functions; since our hardware updates happen under > vblank evasion, we're not supposed to be calling potentially sleeping > functions there (since int

[Intel-gfx] [RFC 03/15] drm/i915: Update sprite watermarks outside vblank evasion

2015-05-20 Thread Matt Roper
We never removed the sprite watermark updates from our low-level foo_update_plane() functions; since our hardware updates happen under vblank evasion, we're not supposed to be calling potentially sleeping functions there (since interrupts are disabled). Ensure that we properly set the atomic.updat