Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-08 Thread Niranjana Vishwanathapura
On Thu, Jul 07, 2022 at 12:32:14AM -0700, Hellstrom, Thomas wrote: On Wed, 2022-07-06 at 22:01 -0700, Niranjana Vishwanathapura wrote: > > + /** > > +* true: allow only vm_bind method of binding. > > +* false: allow only legacy execbuff method of binding. > > +*/ >

Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-07 Thread Hellstrom, Thomas
On Wed, 2022-07-06 at 22:01 -0700, Niranjana Vishwanathapura wrote: > > > +   /** > > > +    * true: allow only vm_bind method of binding. > > > +    * false: allow only legacy execbuff method of binding. > > > +    */ > > > > Use proper kerneldoc. (Same holds for structure documen

Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-06 Thread Niranjana Vishwanathapura
On Thu, Jul 07, 2022 at 03:18:15AM +0200, Andi Shyti wrote: Hi, [...] > +/* > + * VM_BIND feature version supported. > + * > + * The following versions of VM_BIND have been defined: > + * > + * 0: No VM_BIND support. > + * > + * 1: In VM_UNBIND calls, the UMD must specify the exact mappings >

Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-06 Thread Niranjana Vishwanathapura
On Tue, Jul 05, 2022 at 02:59:24AM -0700, Hellstrom, Thomas wrote: Hi, On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: Add VM_BIND and VM_UNBIND ioctls to bind/unbind a section of an object at the specified GPU virtual addresses. Add I915_PARAM_VM_BIND_VERSION to indicate

Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-06 Thread Andi Shyti
Hi, [...] > > +/* > > + * VM_BIND feature version supported. > > + * > > + * The following versions of VM_BIND have been defined: > > + * > > + * 0: No VM_BIND support. > > + * > > + * 1: In VM_UNBIND calls, the UMD must specify the exact mappings > > created > > + *    previously with VM_BIND, t

Re: [Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-05 Thread Hellstrom, Thomas
Hi, On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote: > Add VM_BIND and VM_UNBIND ioctls to bind/unbind a section of an > object at the specified GPU virtual addresses. > > Add I915_PARAM_VM_BIND_VERSION to indicate version of VM_BIND feature > supported and I915_VM_CREATE_FLAG

[Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

2022-07-01 Thread Niranjana Vishwanathapura
Add VM_BIND and VM_UNBIND ioctls to bind/unbind a section of an object at the specified GPU virtual addresses. Add I915_PARAM_VM_BIND_VERSION to indicate version of VM_BIND feature supported and I915_VM_CREATE_FLAGS_USE_VM_BIND for UMDs to select the vm_bind mode of binding. Signed-off-by: Niranj