Re: [Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-22 Thread Gaurav, Kumar
a) How are you scheduling flips for ChromeOS HWDRM overlays(not primary planes)? b) For this you need to understand race. The race is between - Display HW detecting that there is HDCP display config change and deciding to destroy crypto context vs. Display HW flipping HWDRM protected surface.

Re: [Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-22 Thread Ville Syrjälä
On Thu, Jan 21, 2021 at 09:34:53PM +, Gaurav, Kumar wrote: > So the idea is to perform HWDRM session check in flip IRQL and i915 PXP will > guarantee that IRQL is not blocked. > We have done similar check in Windows flip IRQL. > What's an flip IRQL? Some sort of flip related irq handler?

Re: [Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-21 Thread Gaurav, Kumar
So the idea is to perform HWDRM session check in flip IRQL and i915 PXP will guarantee that IRQL is not blocked. We have done similar check in Windows flip IRQL. -Original Message- From: Ville Syrjälä Sent: Thursday, January 21, 2021 1:00 PM To: Gaurav, Kumar Cc: Gupta, Anshuman ; H

Re: [Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-21 Thread Ville Syrjälä
On Thu, Jan 21, 2021 at 08:50:18PM +, Gaurav, Kumar wrote: > Thanks Anshuman for adding me for review. > > Actually, using plane Gamma is good idea to show black frame. Another option > could be alpha value since we know for ChromeOS protected buffer will always > be flipped on overlays. >

Re: [Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-21 Thread Gaurav, Kumar
Thanks Anshuman for adding me for review. Actually, using plane Gamma is good idea to show black frame. Another option could be alpha value since we know for ChromeOS protected buffer will always be flipped on overlays. Below explanation captures need for black frame in i915 Display for HWDRM

Re: [Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-21 Thread Ville Syrjälä
On Tue, Jan 19, 2021 at 09:35:18AM +, Gupta, Anshuman wrote: > Jani/Ville > I had received an offline comment form Gaurav on this patch, > See below, > > -Original Message- > > From: Huang, Sean Z > > Sent: Tuesday, January 19, 2021 1:13 PM > > To: Intel-gfx@lists.freedesktop.org > > C

Re: [Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-19 Thread Gupta, Anshuman
Jani/Ville I had received an offline comment form Gaurav on this patch, See below, > -Original Message- > From: Huang, Sean Z > Sent: Tuesday, January 19, 2021 1:13 PM > To: Intel-gfx@lists.freedesktop.org > Cc: Gaurav, Kumar ; Gupta, Anshuman > ; Bommu, Krishnaiah > ; Huang, Sean Z > Sub

[Intel-gfx] [RFC-v23 13/13] drm/i915/pxp: Add plane decryption support

2021-01-18 Thread Huang, Sean Z
From: Anshuman Gupta Add support to enable/disable PLANE_SURF Decryption Request bit. It requires only to enable plane decryption support when following condition met. 1. PXP session is enabled. 2. Buffer object is protected. v2: - Rebased to libva_cp-drm-tip_tgl_cp tree. - Used gen fb obj user_