Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-16 Thread Paulo Zanoni
2012/1/16 Dave Airlie : > > Okay I must have missed the bit where you explain why a connector > property isn't used? The registers that contain the rotation information are the pipe registers and, as far as I understood, each pipe is associated with only one crtc. We can have more than one connect

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-16 Thread Dave Airlie
On Mon, Jan 16, 2012 at 7:59 PM, Paulo Zanoni wrote: > Hi > > 2012/1/5 Jakob Bornecrantz : >> Couldn't this be done by just adding a property instead of a ioctl? >> > > So I've discussed this with Jesse and it seems the best way to turn > this into a property is to add support for CRTC properties,

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-16 Thread Paulo Zanoni
Hi 2012/1/5 Jakob Bornecrantz : > Couldn't this be done by just adding a property instead of a ioctl? > So I've discussed this with Jesse and it seems the best way to turn this into a property is to add support for CRTC properties, then add a "rotation" property for the i915 driver. This will act

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-06 Thread Jesse Barnes
On Thu, 05 Jan 2012 19:10:43 -0800 Eric Anholt wrote: > On Thu, 5 Jan 2012 14:16:23 -0200, przan...@gmail.com wrote: > > From: Paulo Zanoni > > > > This ioctl is used to signal the drivers that the screen is rotated, > > not to make the drivers rotate the screen. > > - add a driver-specific "

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-05 Thread Eric Anholt
On Thu, 5 Jan 2012 14:16:23 -0200, przan...@gmail.com wrote: > From: Paulo Zanoni > > This ioctl is used to signal the drivers that the screen is rotated, > not to make the drivers rotate the screen. > - add a driver-specific "rotation_set" function > - implement Intel's rotation_set by settin

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-05 Thread Chris Wilson
On Thu, 5 Jan 2012 14:16:23 -0200, przan...@gmail.com wrote: > From: Paulo Zanoni > > This ioctl is used to signal the drivers that the screen is rotated, > not to make the drivers rotate the screen. > - add a driver-specific "rotation_set" function > - implement Intel's rotation_set by settin

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-05 Thread Paulo Zanoni
Hi 2012/1/5 Daniel Vetter : > - Please post at least a link to the userspace patches, so that it's >  possible to check how this all fits together libdrm: http://people.freedesktop.org/~pzanoni/0001-Implement-drmModeCrtcSetRotation.patch xf86-video-intel: http://people.freedesktop.org/~pzanoni/0

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-05 Thread Daniel Vetter
On Thu, Jan 05, 2012 at 02:16:23PM -0200, przan...@gmail.com wrote: > From: Paulo Zanoni > > This ioctl is used to signal the drivers that the screen is rotated, > not to make the drivers rotate the screen. > - add a driver-specific "rotation_set" function > - implement Intel's rotation_set by

[Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-05 Thread przanoni
From: Paulo Zanoni This ioctl is used to signal the drivers that the screen is rotated, not to make the drivers rotate the screen. - add a driver-specific "rotation_set" function - implement Intel's rotation_set by setting the right values to the PIPECONF registers. The idea is that when us