Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-05-06 Thread Tvrtko Ursulin
On 05/04/2015 02:20 PM, Daniel Vetter wrote: On Fri, Apr 24, 2015 at 09:31:56AM +0100, Tvrtko Ursulin wrote: On 04/23/2015 08:15 PM, Daniel Vetter wrote: On Tue, Apr 21, 2015 at 01:18:57PM +0100, Tvrtko Ursulin wrote: On 04/21/2015 11:07 AM, Chris Wilson wrote: On Tue, Apr 21, 2015 at 11:01

Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-05-04 Thread Daniel Vetter
On Fri, Apr 24, 2015 at 09:31:56AM +0100, Tvrtko Ursulin wrote: > > On 04/23/2015 08:15 PM, Daniel Vetter wrote: > >On Tue, Apr 21, 2015 at 01:18:57PM +0100, Tvrtko Ursulin wrote: > >>On 04/21/2015 11:07 AM, Chris Wilson wrote: > >>>On Tue, Apr 21, 2015 at 11:01:03AM +0100, Tvrtko Ursulin wrote: >

Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-04-24 Thread Tvrtko Ursulin
On 04/23/2015 08:15 PM, Daniel Vetter wrote: On Tue, Apr 21, 2015 at 01:18:57PM +0100, Tvrtko Ursulin wrote: On 04/21/2015 11:07 AM, Chris Wilson wrote: On Tue, Apr 21, 2015 at 11:01:03AM +0100, Tvrtko Ursulin wrote: Hi, On 04/21/2015 10:51 AM, Chris Wilson wrote: On Tue, Apr 21, 2015 at 1

Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-04-23 Thread Chris Wilson
On Thu, Apr 23, 2015 at 09:15:41PM +0200, Daniel Vetter wrote: > On Tue, Apr 21, 2015 at 01:18:57PM +0100, Tvrtko Ursulin wrote: > > Interesting, well, I had a look around and this means all sorts of "trouble" > > (refactoring) if proper wm param comparison is to be done. > > > > Alternatively, in

Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-04-23 Thread Daniel Vetter
On Tue, Apr 21, 2015 at 01:18:57PM +0100, Tvrtko Ursulin wrote: > On 04/21/2015 11:07 AM, Chris Wilson wrote: > >On Tue, Apr 21, 2015 at 11:01:03AM +0100, Tvrtko Ursulin wrote: > >> > >>Hi, > >> > >>On 04/21/2015 10:51 AM, Chris Wilson wrote: > >>>On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ur

Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-04-21 Thread Tvrtko Ursulin
On 04/21/2015 11:07 AM, Chris Wilson wrote: On Tue, Apr 21, 2015 at 11:01:03AM +0100, Tvrtko Ursulin wrote: Hi, On 04/21/2015 10:51 AM, Chris Wilson wrote: On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoids duplicating the code. Signed-off-by: Tvr

Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-04-21 Thread Chris Wilson
On Tue, Apr 21, 2015 at 11:01:03AM +0100, Tvrtko Ursulin wrote: > > Hi, > > On 04/21/2015 10:51 AM, Chris Wilson wrote: > >On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Avoids duplicating the code. > >> > >>Signed-off-by: Tvrtko Ursulin > >>Cc

Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-04-21 Thread Tvrtko Ursulin
Hi, On 04/21/2015 10:51 AM, Chris Wilson wrote: On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Avoids duplicating the code. Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter Cc: Sonika Jindal Cc: Damien Lespiau --- Can we do this? Sure, but I'd like

Re: [Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-04-21 Thread Chris Wilson
On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Avoids duplicating the code. > > Signed-off-by: Tvrtko Ursulin > Cc: Daniel Vetter > Cc: Sonika Jindal > Cc: Damien Lespiau > --- > Can we do this? Sure, but I'd like to see update_primary_plane split

[Intel-gfx] [RFC] drm/i915/skl: Use plane update function from mmio flips

2015-04-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Avoids duplicating the code. Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter Cc: Sonika Jindal Cc: Damien Lespiau --- Can we do this? --- drivers/gpu/drm/i915/intel_display.c | 44 1 file changed, 4 insertions(+), 40 deletions(-) di