Re: [Intel-gfx] [PATCH v9 4/6] drm/i915: Interrupt driven fences

2016-06-14 Thread Tvrtko Ursulin
On 13/06/16 16:51, John Harrison wrote: [snip] diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index 07edaed..f8f60bb 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1019,9 +1019,13 @@ static int i915_workqueues_init(struct

Re: [Intel-gfx] [PATCH v9 4/6] drm/i915: Interrupt driven fences

2016-06-13 Thread John Harrison
On 07/06/2016 13:02, Maarten Lankhorst wrote: Op 02-06-16 om 15:25 schreef Tvrtko Ursulin: On 01/06/16 18:07, john.c.harri...@intel.com wrote: From: John Harrison The intended usage model for struct fence is that the signalled status should be set on demand rather than polled. That is, there

Re: [Intel-gfx] [PATCH v9 4/6] drm/i915: Interrupt driven fences

2016-06-07 Thread Tvrtko Ursulin
On 07/06/16 13:02, Maarten Lankhorst wrote: Op 02-06-16 om 15:25 schreef Tvrtko Ursulin: [snip] +return; + +if (!fence_locked) +spin_lock_irqsave(&engine->fence_lock, flags); Not called from hard irq context so can be just spin_lock_irq. But if you agree to go with the

Re: [Intel-gfx] [PATCH v9 4/6] drm/i915: Interrupt driven fences

2016-06-07 Thread Maarten Lankhorst
Op 02-06-16 om 15:25 schreef Tvrtko Ursulin: > > On 01/06/16 18:07, john.c.harri...@intel.com wrote: >> From: John Harrison >> >> The intended usage model for struct fence is that the signalled status >> should be set on demand rather than polled. That is, there should not >> be a need for a 'sign

Re: [Intel-gfx] [PATCH v9 4/6] drm/i915: Interrupt driven fences

2016-06-02 Thread Tvrtko Ursulin
On 01/06/16 18:07, john.c.harri...@intel.com wrote: From: John Harrison The intended usage model for struct fence is that the signalled status should be set on demand rather than polled. That is, there should not be a need for a 'signaled' function to be called everytime the status is queried.

[Intel-gfx] [PATCH v9 4/6] drm/i915: Interrupt driven fences

2016-06-01 Thread John . C . Harrison
From: John Harrison The intended usage model for struct fence is that the signalled status should be set on demand rather than polled. That is, there should not be a need for a 'signaled' function to be called everytime the status is queried. Instead, 'something' should be done to enable a signal