Re: [Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-05 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-10-05 12:21:12) > Quoting Tvrtko Ursulin (2018-10-05 09:34:35) > > > > On 04/10/2018 15:32, Joonas Lahtinen wrote: > > > Some comments below, mostly related to trying to keep the uapi header > > > nice and tidy. > > > > > > Quoting Tvrtko Ursulin (2018-10-04 14:32:48) >

Re: [Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-05 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-05 09:34:35) > > On 04/10/2018 15:32, Joonas Lahtinen wrote: > > Some comments below, mostly related to trying to keep the uapi header > > nice and tidy. > > > > Quoting Tvrtko Ursulin (2018-10-04 14:32:48) > >> @@ -1747,6 +1748,52 @@ struct drm_i915_query_topology

Re: [Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-05 Thread Tvrtko Ursulin
On 04/10/2018 15:32, Joonas Lahtinen wrote: Some comments below, mostly related to trying to keep the uapi header nice and tidy. Quoting Tvrtko Ursulin (2018-10-04 14:32:48) @@ -1747,6 +1748,52 @@ struct drm_i915_query_topology_info { __u8 data[]; }; +/** + * struct drm_i915_eng

Re: [Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-04 Thread Joonas Lahtinen
Some comments below, mostly related to trying to keep the uapi header nice and tidy. Quoting Tvrtko Ursulin (2018-10-04 14:32:48) > @@ -1747,6 +1748,52 @@ struct drm_i915_query_topology_info { > __u8 data[]; > }; > > +/** > + * struct drm_i915_engine_info > + * > + * Describes one engin

Re: [Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-04 Thread Lionel Landwerlin
On 04/10/2018 13:32, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the generic i915 query ioctl is added named DRM_

[Intel-gfx] [PATCH v7] drm/i915: Engine discovery query

2018-10-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the generic i915 query ioctl is added named DRM_I915_QUERY_ENGINE_INFO, together with accompa