Re: [Intel-gfx] [PATCH v6 63/64] drm/i915: Move gt_revoke() slightly

2021-01-18 Thread Maarten Lankhorst
Op 18-01-2021 om 16:05 schreef Thomas Hellström: > > On 1/18/21 3:46 PM, Maarten Lankhorst wrote: >> Op 18-01-2021 om 14:28 schreef Thomas Hellström: >>> On 1/18/21 2:22 PM, Thomas Hellström wrote: On 1/18/21 1:01 PM, Maarten Lankhorst wrote: > Op 18-01-2021 om 12:11 schreef Thomas Hellstr

Re: [Intel-gfx] [PATCH v6 63/64] drm/i915: Move gt_revoke() slightly

2021-01-18 Thread Thomas Hellström
On 1/18/21 3:46 PM, Maarten Lankhorst wrote: Op 18-01-2021 om 14:28 schreef Thomas Hellström: On 1/18/21 2:22 PM, Thomas Hellström wrote: On 1/18/21 1:01 PM, Maarten Lankhorst wrote: Op 18-01-2021 om 12:11 schreef Thomas Hellström: On 1/5/21 4:35 PM, Maarten Lankhorst wrote: We get a lockde

Re: [Intel-gfx] [PATCH v6 63/64] drm/i915: Move gt_revoke() slightly

2021-01-18 Thread Maarten Lankhorst
Op 18-01-2021 om 14:28 schreef Thomas Hellström: > > On 1/18/21 2:22 PM, Thomas Hellström wrote: >> >> On 1/18/21 1:01 PM, Maarten Lankhorst wrote: >>> Op 18-01-2021 om 12:11 schreef Thomas Hellström: On 1/5/21 4:35 PM, Maarten Lankhorst wrote: > We get a lockdep splat when the reset mutex

Re: [Intel-gfx] [PATCH v6 63/64] drm/i915: Move gt_revoke() slightly

2021-01-18 Thread Thomas Hellström
On 1/18/21 2:22 PM, Thomas Hellström wrote: On 1/18/21 1:01 PM, Maarten Lankhorst wrote: Op 18-01-2021 om 12:11 schreef Thomas Hellström: On 1/5/21 4:35 PM, Maarten Lankhorst wrote: We get a lockdep splat when the reset mutex is held, because it can be taken from fence_wait. This conflicts w

Re: [Intel-gfx] [PATCH v6 63/64] drm/i915: Move gt_revoke() slightly

2021-01-18 Thread Thomas Hellström
On 1/18/21 1:01 PM, Maarten Lankhorst wrote: Op 18-01-2021 om 12:11 schreef Thomas Hellström: On 1/5/21 4:35 PM, Maarten Lankhorst wrote: We get a lockdep splat when the reset mutex is held, because it can be taken from fence_wait. This conflicts with the mmu notifier we have, because we recur

Re: [Intel-gfx] [PATCH v6 63/64] drm/i915: Move gt_revoke() slightly

2021-01-18 Thread Maarten Lankhorst
Op 18-01-2021 om 12:11 schreef Thomas Hellström: > > On 1/5/21 4:35 PM, Maarten Lankhorst wrote: >> We get a lockdep splat when the reset mutex is held, because it can be >> taken from fence_wait. This conflicts with the mmu notifier we have, >> because we recurse between reset mutex and mmap lock

Re: [Intel-gfx] [PATCH v6 63/64] drm/i915: Move gt_revoke() slightly

2021-01-18 Thread Thomas Hellström
On 1/5/21 4:35 PM, Maarten Lankhorst wrote: We get a lockdep splat when the reset mutex is held, because it can be taken from fence_wait. This conflicts with the mmu notifier we have, because we recurse between reset mutex and mmap lock -> mmu notifier. Remove this recursion by calling revoke_

[Intel-gfx] [PATCH v6 63/64] drm/i915: Move gt_revoke() slightly

2021-01-05 Thread Maarten Lankhorst
We get a lockdep splat when the reset mutex is held, because it can be taken from fence_wait. This conflicts with the mmu notifier we have, because we recurse between reset mutex and mmap lock -> mmu notifier. Remove this recursion by calling revoke_mmaps before taking the lock. Signed-off-by: Ma