Re: [Intel-gfx] [PATCH v6 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider

2015-06-05 Thread Jani Nikula
On Thu, 04 Jun 2015, Ville Syrjälä wrote: > On Thu, Jun 04, 2015 at 04:24:43PM +0300, Jani Nikula wrote: >> On Wed, 03 Jun 2015, Mika Kahola wrote: >> > From: Ville Syrjälä >> > >> > ilk_get_aux_clock_divider() is now a subset of >> > hsw_get_aux_clock_divider() so unify them. >> >> I do like t

Re: [Intel-gfx] [PATCH v6 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider

2015-06-04 Thread Ville Syrjälä
On Thu, Jun 04, 2015 at 04:24:43PM +0300, Jani Nikula wrote: > On Wed, 03 Jun 2015, Mika Kahola wrote: > > From: Ville Syrjälä > > > > ilk_get_aux_clock_divider() is now a subset of > > hsw_get_aux_clock_divider() so unify them. > > I do like the clarity of having these two separate, I see no c

Re: [Intel-gfx] [PATCH v6 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider

2015-06-04 Thread Jani Nikula
On Wed, 03 Jun 2015, Mika Kahola wrote: > From: Ville Syrjälä > > ilk_get_aux_clock_divider() is now a subset of > hsw_get_aux_clock_divider() so unify them. I do like the clarity of having these two separate, especially with the early return in the ilk version and the w/a in the hsw/bdw version

[Intel-gfx] [PATCH v6 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider

2015-06-03 Thread Mika Kahola
From: Ville Syrjälä ilk_get_aux_clock_divider() is now a subset of hsw_get_aux_clock_divider() so unify them. v2: Rebased to the latest v3: Rebased to the latest v4: Fix for patch style problems Signed-off-by: Ville Syrjälä Signed-off-by: Mika Kahola Author:Ville Syrjälä --- drivers/gp