Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-22 Thread Jani Nikula
On Thu, 21 Sep 2017, Michal Wajdeczko wrote: > If there is an agreement on merging first patch, can someone give it > r-b and merge ? Note that this patch is prone to rebase conflicts. Pushed the first patch, thanks. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center __

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-21 Thread Jani Nikula
On Wed, 20 Sep 2017, Joonas Lahtinen wrote: > On Wed, 2017-09-20 at 15:01 +0300, Jani Nikula wrote: >> On Wed, 20 Sep 2017, Joonas Lahtinen wrote: >> > On Tue, 2017-09-19 at 19:38 +, Michal Wajdeczko wrote: >> > > We should discourage developers from modifying modparams. >> > > Introduce spec

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-21 Thread Michal Wajdeczko
On Wed, 20 Sep 2017 15:07:50 +0200, Joonas Lahtinen wrote: On Wed, 2017-09-20 at 15:01 +0300, Jani Nikula wrote: On Wed, 20 Sep 2017, Joonas Lahtinen wrote: > On Tue, 2017-09-19 at 19:38 +, Michal Wajdeczko wrote: > > We should discourage developers from modifying modparams. > > Intro

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-20 Thread Joonas Lahtinen
On Wed, 2017-09-20 at 15:01 +0300, Jani Nikula wrote: > On Wed, 20 Sep 2017, Joonas Lahtinen wrote: > > On Tue, 2017-09-19 at 19:38 +, Michal Wajdeczko wrote: > > > We should discourage developers from modifying modparams. > > > Introduce special macro for easier tracking of changes done > > >

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-20 Thread Joonas Lahtinen
On Wed, 2017-09-20 at 15:06 +0300, Joonas Lahtinen wrote: > On Wed, 2017-09-20 at 11:34 +0300, Jani Nikula wrote: > > On Tue, 19 Sep 2017, Michal Wajdeczko wrote: > > > We should discourage developers from modifying modparams. > > > Introduce special macro for easier tracking of changes done > > >

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-20 Thread Joonas Lahtinen
On Wed, 2017-09-20 at 11:34 +0300, Jani Nikula wrote: > On Tue, 19 Sep 2017, Michal Wajdeczko wrote: > > We should discourage developers from modifying modparams. > > Introduce special macro for easier tracking of changes done > > in modparams and enforce its use by defining existing modparams > >

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-20 Thread Jani Nikula
On Wed, 20 Sep 2017, Joonas Lahtinen wrote: > On Tue, 2017-09-19 at 19:38 +, Michal Wajdeczko wrote: >> We should discourage developers from modifying modparams. >> Introduce special macro for easier tracking of changes done >> in modparams and enforce its use by defining existing modparams >>

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-20 Thread Ville Syrjälä
On Wed, Sep 20, 2017 at 11:54:03AM +0200, Michal Wajdeczko wrote: > On Wed, 20 Sep 2017 10:34:43 +0200, Jani Nikula > wrote: > > > On Tue, 19 Sep 2017, Michal Wajdeczko wrote: > >> We should discourage developers from modifying modparams. > >> Introduce special macro for easier tracking of cha

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-20 Thread Joonas Lahtinen
On Tue, 2017-09-19 at 19:38 +, Michal Wajdeczko wrote: > We should discourage developers from modifying modparams. > Introduce special macro for easier tracking of changes done > in modparams and enforce its use by defining existing modparams > members as const. Note that defining whole modpara

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-20 Thread Michal Wajdeczko
On Wed, 20 Sep 2017 10:34:43 +0200, Jani Nikula wrote: On Tue, 19 Sep 2017, Michal Wajdeczko wrote: We should discourage developers from modifying modparams. Introduce special macro for easier tracking of changes done in modparams and enforce its use by defining existing modparams members a

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-20 Thread Jani Nikula
On Tue, 19 Sep 2017, Michal Wajdeczko wrote: > We should discourage developers from modifying modparams. > Introduce special macro for easier tracking of changes done > in modparams and enforce its use by defining existing modparams > members as const. Note that defining whole modparams struct > a

[Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

2017-09-19 Thread Michal Wajdeczko
We should discourage developers from modifying modparams. Introduce special macro for easier tracking of changes done in modparams and enforce its use by defining existing modparams members as const. Note that defining whole modparams struct as const makes checkpatch unhappy. v2: rebased Credits-