Re: [Intel-gfx] [PATCH v6 19/24] drm/i915/dg1: enable PORT C/D aka D/E

2020-09-30 Thread Matt Roper
On Tue, Sep 29, 2020 at 11:42:29PM -0700, Lucas De Marchi wrote: > For DG1 we have a little of mix up wrt to DDI/port names and indexes. > Bspec refers to the ports as DDIA, DDIB, DDI USBC1 and DDI USBC2 > (besides the DDIA, DDIB, DDIC, DDID), but the previous naming is the > most unambiguous one.

[Intel-gfx] [PATCH v6 19/24] drm/i915/dg1: enable PORT C/D aka D/E

2020-09-29 Thread Lucas De Marchi
For DG1 we have a little of mix up wrt to DDI/port names and indexes. Bspec refers to the ports as DDIA, DDIB, DDI USBC1 and DDI USBC2 (besides the DDIA, DDIB, DDIC, DDID), but the previous naming is the most unambiguous one. This means that for any register on Display Engine we should use the inde