Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-20 Thread Sharma, Shashank
om; Roper, Matthew D; Bradford, Robert; Matheson, Annie J; kausalmall...@gmail.com; Vetter, Daniel Subject: RE: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction Yes, please note that as per the discussion, the legacy gamma IOCTL is still existing, to maintain the backward co

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-20 Thread Sharma, Shashank
, Matthew D; Bradford, Robert; Matheson, Annie J; kausalmall...@gmail.com; Vetter, Daniel Subject: Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction On Mon, Oct 19, 2015 at 10:27:17PM +, Smith, Gary K wrote: > Unless legacy mode enables it of course. I thought

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-20 Thread Daniel Vetter
On Mon, Oct 19, 2015 at 10:27:17PM +, Smith, Gary K wrote: > Unless legacy mode enables it of course. I thought we decided to ignore legacy gamma stuff (at least for now, until someone complains about the inconsistency). So yeah, I think we're fine. -Daniel > > Thanks > Gary > > > "Smith,

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-19 Thread Sharma, Shashank
@gmail.com>; Vetter, Daniel Subject: Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction Unless legacy mode enables it of course. Thanks Gary "Smith, Gary K" mailto:gary.k.sm...@intel.com>> wrote: Bear in mind that it will only happen after the prop

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-19 Thread Matheson, Annie J
el-gfx@lists.freedesktop.org; emil.l.veli...@gmail.com; Roper, Matthew D; Bradford, Robert; Matheson, Annie J; kausalmall...@gmail.com; Vetter, Daniel Subject: Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction Unless legacy mode enables it of course. Thanks Gary "Sm

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-19 Thread Smith, Gary K
Unless legacy mode enables it of course. Thanks Gary "Smith, Gary K" wrote: Bear in mind that it will only happen after the property has been set. Initially there will be no clients setting the property - so I think it should be OK. Thanks Gary Daniel Vetter wrote: On Mon, Oct 19, 2015

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-19 Thread Smith, Gary K
Bear in mind that it will only happen after the property has been set. Initially there will be no clients setting the property - so I think it should be OK. Thanks Gary Daniel Vetter wrote: On Mon, Oct 19, 2015 at 08:39:54PM +, Bish, Jim wrote: > > > On 10/19/2015 11:54 AM, Daniel Vetter

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-19 Thread Daniel Vetter
On Mon, Oct 19, 2015 at 08:39:54PM +, Bish, Jim wrote: > > > On 10/19/2015 11:54 AM, Daniel Vetter wrote: > > On Mon, Oct 19, 2015 at 06:08:52PM +, Smith, Gary K wrote: > >> FYI - this shouldn't block the commits, but should be optimized later > >> (fairly soon). > >> > >> I believe the

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-19 Thread Bish, Jim
On 10/19/2015 11:54 AM, Daniel Vetter wrote: > On Mon, Oct 19, 2015 at 06:08:52PM +, Smith, Gary K wrote: >> FYI - this shouldn't block the commits, but should be optimized later >> (fairly soon). >> >> I believe the current implementation ends up executing >> while (count < C

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-19 Thread Daniel Vetter
On Mon, Oct 19, 2015 at 06:08:52PM +, Smith, Gary K wrote: > FYI - this shouldn't block the commits, but should be optimized later (fairly > soon). > > I believe the current implementation ends up executing > while (count < CHV_DEGAMMA_MAX_VALS) { > // Do

Re: [Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-19 Thread Smith, Gary K
FYI - this shouldn't block the commits, but should be optimized later (fairly soon). I believe the current implementation ends up executing while (count < CHV_DEGAMMA_MAX_VALS) { // Do lots of caclulation I915_WRITE(cgm_degamma_reg

[Intel-gfx] [PATCH v6 14/23] drm/i915: CHV: Pipe level degamma correction

2015-10-16 Thread Shashank Sharma
CHV/BSW supports Degamma color correction, which linearizes all the non-linear color values. This will be applied before Color Transformation. This patch does the following: 1. Attach deGamma property to CRTC 2. Add the core function to program DeGamma correction values for CHV/BSW platform 2.