Re: [Intel-gfx] [PATCH v6 1/3] drm/i915/migrate: Account for the reserved_space

2022-12-06 Thread Andi Shyti
Hi Matt, On Fri, Dec 02, 2022 at 12:28:42PM +, Matthew Auld wrote: > From: Chris Wilson > > If the ring is nearly full when calling into emit_pte(), we might > incorrectly trample the reserved_space when constructing the packet to > emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserv

Re: [Intel-gfx] [PATCH v6 1/3] drm/i915/migrate: Account for the reserved_space

2022-12-06 Thread Andrzej Hajda
Hi, I messed-up with versions, my prev comment landed in v2, so I put it here to clean things up. On 02.12.2022 13:28, Matthew Auld wrote: From: Chris Wilson If the ring is nearly full when calling into emit_pte(), we might incorrectly trample the reserved_space when constructing the packet

[Intel-gfx] [PATCH v6 1/3] drm/i915/migrate: Account for the reserved_space

2022-12-02 Thread Matthew Auld
From: Chris Wilson If the ring is nearly full when calling into emit_pte(), we might incorrectly trample the reserved_space when constructing the packet to emit the PTEs. This then triggers the GEM_BUG_ON(rq->reserved_space > ring->space) when later submitting the request, since the request itsel