Re: [Intel-gfx] [PATCH v6] drm/kmb: Add support for KeemBay Display

2020-08-31 Thread Chrisanthus, Anitha
Hi Sam, Thanks a lot for the review. I will address your comments in v7. For those that are not addressed, please see my reply inline. Regards, Anitha > -Original Message- > From: Sam Ravnborg > Sent: Thursday, August 20, 2020 1:10 PM > To: Chrisanthus, Anitha > Cc: dri-de...@lists.fre

Re: [Intel-gfx] [PATCH v6] drm/kmb: Add support for KeemBay Display

2020-08-20 Thread Sam Ravnborg
Hi Anitha. Feedback on kmb_dsi. The main feedback can be found after the kmb_dsi_init function. The highligt of the feedback is that, in my opinion, the best would be to use the drm_bridge abstraction for the kmb_dsi. Maybe because I am biased - and this is just overhead. But it just looks simple

Re: [Intel-gfx] [PATCH v6] drm/kmb: Add support for KeemBay Display

2020-08-20 Thread Sam Ravnborg
Hi Anitha. On Mon, Aug 10, 2020 at 02:53:38PM -0700, Anitha Chrisanthus wrote: > This is a basic KMS atomic modesetting display driver for KeemBay family of > SOCs. Driver has no 2D or 3D graphics.It calls into the ADV bridge > driver at the connector level. > > Single CRTC with LCD controller->m