Re: [Intel-gfx] [PATCH v6] drm/i915: Engine discovery query

2018-10-05 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-05 09:26:37) > > On 04/10/2018 17:33, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-10-04 11:51:18) > >> From: Tvrtko Ursulin > >> > >> Engine discovery query allows userspace to enumerate engines, probe their > >> configuration features, all without needing

Re: [Intel-gfx] [PATCH v6] drm/i915: Engine discovery query

2018-10-05 Thread Tvrtko Ursulin
On 04/10/2018 17:33, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-04 11:51:18) From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the

Re: [Intel-gfx] [PATCH v6] drm/i915: Engine discovery query

2018-10-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-04 11:51:18) > From: Tvrtko Ursulin > > Engine discovery query allows userspace to enumerate engines, probe their > configuration features, all without needing to maintain the internal PCI > ID based database. > > A new query for the generic i915 query ioctl is ad

Re: [Intel-gfx] [PATCH v6] drm/i915: Engine discovery query

2018-10-04 Thread Tvrtko Ursulin
On 04/10/2018 12:03, Lionel Landwerlin wrote: On 04/10/2018 12:51, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for

Re: [Intel-gfx] [PATCH v6] drm/i915: Engine discovery query

2018-10-04 Thread Lionel Landwerlin
Other than the nitpicking, I can't see anything wrong with this patch. - Lionel On 04/10/2018 13:03, Lionel Landwerlin wrote: On 04/10/2018 12:51, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, al

Re: [Intel-gfx] [PATCH v6] drm/i915: Engine discovery query

2018-10-04 Thread Lionel Landwerlin
On 04/10/2018 12:51, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the generic i915 query ioctl is added named DRM_

[Intel-gfx] [PATCH v6] drm/i915: Engine discovery query

2018-10-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the generic i915 query ioctl is added named DRM_I915_QUERY_ENGINE_INFO, together with accompa