Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-24 Thread Laurent Pinchart
Hi John, On Friday, 24 August 2018 00:12:46 EEST John Stultz wrote: > On Thu, Aug 23, 2018 at 1:49 PM, Laurent Pinchart wrote: > > On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: > >> On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > >>> On Thu, Aug 23, 2018 at 10:46:15AM +0300

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 1:49 PM, Laurent Pinchart wrote: > On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: >> On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: >> > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: >> >> Possibly slightly out of topic, but we're i

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Laurent Pinchart
Hi John, On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: > On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: > >> On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: > >>> On Mon, Aug 20, 2018 at 11:44

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: >> Hi John, >> >> On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: >> > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> > > Hey Noralf, all, >> > > >> > >

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 10:24 AM, Ville Syrjälä wrote: > On Wed, Aug 22, 2018 at 09:14:08PM -0700, John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> > Hey Noralf, all, >> > I've been digging for a bit on the regression that this patch has >> > tripped on the HiKey bo

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 12:46 AM, Laurent Pinchart wrote: > Hi John, > > On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> > Hey Noralf, all, >> > >> > I've been digging for a bit on the regression that this patch has >> > >>

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Ville Syrjälä
On Wed, Aug 22, 2018 at 09:14:08PM -0700, John Stultz wrote: > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > > Hey Noralf, all, > > I've been digging for a bit on the regression that this patch has > > tripped on the HiKey board as reported here: > > https://lkml.org/lkml/2018/8/16/81 >

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Daniel Vetter
On Thu, Aug 23, 2018 at 6:49 PM, Noralf Trønnes wrote: > > Den 23.08.2018 09.37, skrev Daniel Vetter: >> >> On Wed, Aug 22, 2018 at 11:21:11PM -0700, John Stultz wrote: >>> >>> On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrot

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Noralf Trønnes
Den 23.08.2018 09.37, skrev Daniel Vetter: On Wed, Aug 22, 2018 at 11:21:11PM -0700, John Stultz wrote: On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: Hey Noralf, all, I've

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Daniel Vetter
On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: > Hi John, > > On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: > > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > > > Hey Noralf, all, > > > > > > I've been digging for a bit on the regression that this patch

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Laurent Pinchart
Hi John, On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > > Hey Noralf, all, > > > > I've been digging for a bit on the regression that this patch has > > > > tripped on the HiKey board as reported here: > > https://lkml.org/

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 11:21:11PM -0700, John Stultz wrote: > On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: > > On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: > >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz > >> wrote: > >>> Hey Noralf, all, > >>> I've been digging for a bit

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-22 Thread John Stultz
On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: > On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >>> Hey Noralf, all, >>> I've been digging for a bit on the regression that this patch has >>> tripped on the HiKey board as repo

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-22 Thread Daniel Vetter
On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> Hey Noralf, all, >> I've been digging for a bit on the regression that this patch has >> tripped on the HiKey board as reported here: >> https://lkml.org/lkml/2018/8/16/81 >> >> The fir

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-22 Thread John Stultz
On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > Hey Noralf, all, > I've been digging for a bit on the regression that this patch has > tripped on the HiKey board as reported here: > https://lkml.org/lkml/2018/8/16/81 > > The first issue was that the kirin driver was setting > mode_config.

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-22 Thread Daniel Vetter
On Tue, Aug 21, 2018 at 8:43 PM, John Stultz wrote: > On Tue, Aug 21, 2018 at 7:59 AM, Noralf Trønnes wrote: >> Den 21.08.2018 10.44, skrev Daniel Vetter: >>> On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: Since we don't have a drm_gem_cma_object reference in drm_fb_h

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread John Stultz
On Tue, Aug 21, 2018 at 7:59 AM, Noralf Trønnes wrote: > Den 21.08.2018 10.44, skrev Daniel Vetter: >> On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: >>> >>> Since we don't have a drm_gem_cma_object reference in >>> drm_fb_helper_generic_probe(), I instead added: >>> fbi->fix.sme

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Daniel Vetter
On Tue, Aug 21, 2018 at 6:03 PM, Noralf Trønnes wrote: > > Den 21.08.2018 17.41, skrev Daniel Vetter: >> >> On Tue, Aug 21, 2018 at 04:59:46PM +0200, Noralf Trønnes wrote: >>> >>> Den 21.08.2018 10.44, skrev Daniel Vetter: On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote:

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Noralf Trønnes
Den 21.08.2018 17.41, skrev Daniel Vetter: On Tue, Aug 21, 2018 at 04:59:46PM +0200, Noralf Trønnes wrote: Den 21.08.2018 10.44, skrev Daniel Vetter: On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: This switches the CMA help

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Daniel Vetter
On Tue, Aug 21, 2018 at 04:59:46PM +0200, Noralf Trønnes wrote: > > Den 21.08.2018 10.44, skrev Daniel Vetter: > > On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: > > > On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: > > > > This switches the CMA helper drivers that use its fbd

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Noralf Trønnes
Den 21.08.2018 10.44, skrev Daniel Vetter: On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: This switches the CMA helper drivers that use its fbdev emulation over to the generic fbdev emulation. It's the first phase of using ge

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Noralf Trønnes
Den 21.08.2018 08.44, skrev John Stultz: On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: This switches the CMA helper drivers that use its fbdev emulation over to the generic fbdev emulation. It's the first phase of using generic fbdev. A later phase will use DRM client callbacks for the

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-21 Thread Daniel Vetter
On Mon, Aug 20, 2018 at 11:44:56PM -0700, John Stultz wrote: > On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: > > This switches the CMA helper drivers that use its fbdev emulation over > > to the generic fbdev emulation. It's the first phase of using generic > > fbdev. A later phase will us

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-20 Thread John Stultz
On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: > This switches the CMA helper drivers that use its fbdev emulation over > to the generic fbdev emulation. It's the first phase of using generic > fbdev. A later phase will use DRM client callbacks for the > lastclose/hotplug/remove callbacks.

[Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-07-03 Thread Noralf Trønnes
This switches the CMA helper drivers that use its fbdev emulation over to the generic fbdev emulation. It's the first phase of using generic fbdev. A later phase will use DRM client callbacks for the lastclose/hotplug/remove callbacks. There are currently 2 fbdev init/fini functions: - drm_fb_cma_