Re: [Intel-gfx] [PATCH v4 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-27 Thread Teres Alexis, Alan Previn
I've send offline email to clear up session cleanup behavior for hdcp (maybe its a PXP-only thing). But still wanna pursue a bit more on below portion: On Fri, 2022-12-23 at 09:07 +, Kandpal, Suraj wrote: > > > > > > > + memset(cmd, 0, obj->base.size); > > > > Alan: question: how often is

Re: [Intel-gfx] [PATCH v4 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-23 Thread Kandpal, Suraj
> > Most of it looks good - but I have two issues: > 1. I believe there are some reuse efficiency gaps depending on the frequency > of > these hdcp-gsc messages... but it might not be an issue depending on the > answers to the questions i have below. > 2. Missing the session-cleanup request >

Re: [Intel-gfx] [PATCH v4 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-23 Thread Teres Alexis, Alan Previn
Most of it looks good - but I have two issues: 1. I believe there are some reuse efficiency gaps depending on the frequency of these hdcp-gsc messages... but it might not be an issue depending on the answers to the questions i have below. 2. Missing the session-cleanup request ...alan On Thu

[Intel-gfx] [PATCH v4 6/7] drm/i915/mtl: Add function to send command to GSC CS

2022-12-21 Thread Suraj Kandpal
Add function that takes care of sending command to gsc cs. We start of with allocation of memory for our command intel_hdcp_gsc_message that contains gsc cs memory header as directed in specs followed by the actual payload hdcp message that we want to send. Spec states that we need to poll pending