Re: [Intel-gfx] [PATCH v4 5/5] i915: add documentation to intel_engine_cs

2018-04-04 Thread Jani Nikula
On Wed, 04 Apr 2018, Joonas Lahtinen wrote: > To be perfectly clear: Are we working towards a clean make htmldocs and > CI nagging when it gets broken? I'd like that to be the goal, yes. I'm not sure if anyone's working towards that. BR, Jani. -- Jani Nikula, Intel Open Source Technology Cent

Re: [Intel-gfx] [PATCH v4 5/5] i915: add documentation to intel_engine_cs

2018-04-04 Thread Joonas Lahtinen
Quoting Jani Nikula (2018-04-04 12:48:55) > On Wed, 04 Apr 2018, Joonas Lahtinen wrote: > > + Jani for Sphinx > > > > Quoting Rogovin, Kevin (2018-04-03 17:34:49) > >> I am somewhat tempted to just drop this patch or add more documentation. > >> The function pointers are used in the code common >

Re: [Intel-gfx] [PATCH v4 5/5] i915: add documentation to intel_engine_cs

2018-04-04 Thread Jani Nikula
On Wed, 04 Apr 2018, Joonas Lahtinen wrote: > + Jani for Sphinx > > Quoting Rogovin, Kevin (2018-04-03 17:34:49) >> I am somewhat tempted to just drop this patch or add more documentation. The >> function pointers are used in the code common >> to the legacy way and LRC way of submitting batchbuf

Re: [Intel-gfx] [PATCH v4 5/5] i915: add documentation to intel_engine_cs

2018-04-04 Thread Joonas Lahtinen
+ Jani for Sphinx Quoting Rogovin, Kevin (2018-04-03 17:34:49) > I am somewhat tempted to just drop this patch or add more documentation. The > function pointers are used in the code common > to the legacy way and LRC way of submitting batchbuffers to the GPU, so they > should have somekind of c

Re: [Intel-gfx] [PATCH v4 5/5] i915: add documentation to intel_engine_cs

2018-04-03 Thread Rogovin, Kevin
HI, -Original Message- From: Joonas Lahtinen [mailto:joonas.lahti...@linux.intel.com] - snip - >> >> void(*set_default_submission)(struct intel_engine_cs >> *engine); >> >> + /* In addition to pinning the context, returns the intel_ringbuffer >> +

Re: [Intel-gfx] [PATCH v4 5/5] i915: add documentation to intel_engine_cs

2018-04-03 Thread Joonas Lahtinen
Quoting kevin.rogo...@intel.com (2018-04-03 13:52:27) > From: Kevin Rogovin > > Add documentation to a number of the function pointer fields of > intel_engine_cs. > > Signed-off-by: Kevin Rogovin > --- > drivers/gpu/drm/i915/intel_ringbuffer.h | 29 + > 1 file chang

[Intel-gfx] [PATCH v4 5/5] i915: add documentation to intel_engine_cs

2018-04-03 Thread kevin . rogovin
From: Kevin Rogovin Add documentation to a number of the function pointer fields of intel_engine_cs. Signed-off-by: Kevin Rogovin --- drivers/gpu/drm/i915/intel_ringbuffer.h | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer