Re: [Intel-gfx] [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.

2015-04-28 Thread Imre Deak
On to, 2015-04-16 at 14:22 +0530, Animesh Manna wrote: > [...] > + > +#define I915_CSR_SKL "i915/skl_dmc_ver1.bin" Animesh, does this firmware loading patchset work with skl_dmc_ver4.bin? If so please re-send this patch with the above pointing to i915/skl_dmc_ver4.bin (since that is the published

Re: [Intel-gfx] [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.

2015-04-16 Thread Imre Deak
On Thu, 2015-04-16 at 19:53 +0530, Animesh Manna wrote: > > On 4/16/2015 4:55 PM, Imre Deak wrote: > > On to, 2015-04-16 at 17:29 +0530, Animesh Manna wrote: > >> + Jesse, Rodrigo > >> > >> On 04/16/2015 02:51 PM, Imre Deak wrote: > >>> On to, 2015-04-16 at 14:22 +0530, Animesh Manna wrote: >

Re: [Intel-gfx] [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.

2015-04-16 Thread Animesh Manna
On 4/16/2015 4:55 PM, Imre Deak wrote: On to, 2015-04-16 at 17:29 +0530, Animesh Manna wrote: + Jesse, Rodrigo On 04/16/2015 02:51 PM, Imre Deak wrote: On to, 2015-04-16 at 14:22 +0530, Animesh Manna wrote: [...] +#include +#include "i915_drv.h" +#include "i915_reg.h" + +#define I915_CSR_S

Re: [Intel-gfx] [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.

2015-04-16 Thread Imre Deak
On to, 2015-04-16 at 17:29 +0530, Animesh Manna wrote: > + Jesse, Rodrigo > > On 04/16/2015 02:51 PM, Imre Deak wrote: > > On to, 2015-04-16 at 14:22 +0530, Animesh Manna wrote: > >> [...] > >> +#include > >> +#include "i915_drv.h" > >> +#include "i915_reg.h" > >> + > >> +#define I915_CSR_SKL "i9

Re: [Intel-gfx] [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.

2015-04-16 Thread Animesh Manna
+ Jesse, Rodrigo On 04/16/2015 02:51 PM, Imre Deak wrote: On to, 2015-04-16 at 14:22 +0530, Animesh Manna wrote: [...] +#include +#include "i915_drv.h" +#include "i915_reg.h" + +#define I915_CSR_SKL "i915/skl_dmc_ver1.bin" The latest version on the FW download page is skl_dmc_ver4.bin as Dami

Re: [Intel-gfx] [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.

2015-04-16 Thread Imre Deak
On to, 2015-04-16 at 14:22 +0530, Animesh Manna wrote: > [...] > +#include > +#include "i915_drv.h" > +#include "i915_reg.h" > + > +#define I915_CSR_SKL "i915/skl_dmc_ver1.bin" The latest version on the FW download page is skl_dmc_ver4.bin as Damien pointed out and skl_dmc_ver1.bin is not availab

Re: [Intel-gfx] [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.

2015-04-16 Thread Damien Lespiau
On Thu, Apr 16, 2015 at 02:22:07PM +0530, Animesh Manna wrote: > +#define I915_CSR_SKL "i915/skl_dmc_ver1.bin" This needs to be skl_dmc_ver4.bin, because that's the version we made public. -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedeskto

[Intel-gfx] [PATCH v4 1/8] drm/i915/skl: Add support to load SKL CSR firmware.

2015-04-16 Thread Animesh Manna
From: "A.Sunil Kamath" Display Context Save and Restore support is needed for various SKL Display C states like DC5, DC6. This implementation is added based on first version of DMC CSR program that we received from h/w team. Here we are using request_firmware based design. Finally this firmware