Re: [Intel-gfx] [PATCH v4 1/7] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-02-06 Thread Sharma, Shashank
Regards Shashank On 2/2/2018 7:30 PM, Ville Syrjälä wrote: On Fri, Feb 02, 2018 at 11:38:07AM +0530, Sharma, Shashank wrote: Thanks for the comments, mine inline. Regards Shashank On 2/2/2018 12:39 AM, Ville Syrjälä wrote: On Tue, Jan 30, 2018 at 03:05:57PM +0530, Shashank Sharma wrote: Fr

Re: [Intel-gfx] [PATCH v4 1/7] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-02-02 Thread Ville Syrjälä
On Fri, Feb 02, 2018 at 11:38:07AM +0530, Sharma, Shashank wrote: > Thanks for the comments, mine inline. > > Regards > Shashank > On 2/2/2018 12:39 AM, Ville Syrjälä wrote: > > On Tue, Jan 30, 2018 at 03:05:57PM +0530, Shashank Sharma wrote: > >> From: "Sharma, Shashank" > >> > >> Currently, we

Re: [Intel-gfx] [PATCH v4 1/7] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-02-01 Thread Sharma, Shashank
Thanks for the comments, mine inline. Regards Shashank On 2/2/2018 12:39 AM, Ville Syrjälä wrote: On Tue, Jan 30, 2018 at 03:05:57PM +0530, Shashank Sharma wrote: From: "Sharma, Shashank" Currently, we are using a bool in CRTC state (state->ycbcr420), to indicate modeset, that the output form

Re: [Intel-gfx] [PATCH v4 1/7] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-02-01 Thread Ville Syrjälä
On Tue, Jan 30, 2018 at 03:05:57PM +0530, Shashank Sharma wrote: > From: "Sharma, Shashank" > > Currently, we are using a bool in CRTC state (state->ycbcr420), > to indicate modeset, that the output format is YCBCR 4:2:0. Now in > order to support other YCBCR formats, we will need more such flags

Re: [Intel-gfx] [PATCH v4 1/7] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-01-30 Thread Sharma, Shashank
Regards Shashank On 1/30/2018 3:53 PM, Jani Nikula wrote: On Tue, 30 Jan 2018, Shashank Sharma wrote: From: "Sharma, Shashank" Currently, we are using a bool in CRTC state (state->ycbcr420), to indicate modeset, that the output format is YCBCR 4:2:0. Now in order to support other YCBCR for

Re: [Intel-gfx] [PATCH v4 1/7] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-01-30 Thread Jani Nikula
On Tue, 30 Jan 2018, Shashank Sharma wrote: > From: "Sharma, Shashank" > > Currently, we are using a bool in CRTC state (state->ycbcr420), > to indicate modeset, that the output format is YCBCR 4:2:0. Now in > order to support other YCBCR formats, we will need more such flags. > > The idea behind

[Intel-gfx] [PATCH v4 1/7] drm/i915: Add CRTC output format YCBCR 4:2:0

2018-01-30 Thread Shashank Sharma
From: "Sharma, Shashank" Currently, we are using a bool in CRTC state (state->ycbcr420), to indicate modeset, that the output format is YCBCR 4:2:0. Now in order to support other YCBCR formats, we will need more such flags. The idea behind this patch is to replace this bool with an enum, and plu