Re: [Intel-gfx] [PATCH v4 07/38] drm/i915: Start of GPU scheduler

2016-02-19 Thread Joonas Lahtinen
Hi, Adding Daniel as CC to comment below. On to, 2016-02-18 at 14:22 +, John Harrison wrote: > On 20/01/2016 13:18, Joonas Lahtinen wrote: > > On Mon, 2016-01-11 at 18:42 +, john.c.harri...@intel.com wrote: > > > From: John Harrison > > > > > > > > > + this = node->s

Re: [Intel-gfx] [PATCH v4 07/38] drm/i915: Start of GPU scheduler

2016-02-18 Thread John Harrison
On 20/01/2016 13:18, Joonas Lahtinen wrote: Hi, Comments below this pre text. Many of the comments are related to the indent and style of the code. That stuff is important to fix for future maintainability. In order for the future review to be more effective, I'd like to next see a v5 of the se

Re: [Intel-gfx] [PATCH v4 07/38] drm/i915: Start of GPU scheduler

2016-01-20 Thread Joonas Lahtinen
Hi, Comments below this pre text. Many of the comments are related to the indent and style of the code. That stuff is important to fix for future maintainability. In order for the future review to be more effective, I'd like to next see a v5 of the series where the code quality concerns have been

[Intel-gfx] [PATCH v4 07/38] drm/i915: Start of GPU scheduler

2016-01-11 Thread John . C . Harrison
From: John Harrison Initial creation of scheduler source files. Note that this patch implements most of the scheduler functionality but does not hook it in to the driver yet. It also leaves the scheduler code in 'pass through' mode so that even when it is hooked in, it will not actually do very m