Re: [Intel-gfx] [PATCH v4 02/30] drm/dp_mst: Fix fractional DSC bpp handling

2023-11-08 Thread Deucher, Alexander
[Public] > -Original Message- > From: Wentland, Harry > Sent: Wednesday, November 8, 2023 9:40 AM > To: Imre Deak ; intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä ; Manasi Navare > ; Lyude Paul ; Francis, > David ; Mikita Lipski ; > Deucher, Alexander > Subject: Re: [PATCH v4 02/30]

Re: [Intel-gfx] [PATCH v4 02/30] drm/dp_mst: Fix fractional DSC bpp handling

2023-11-08 Thread Harry Wentland
On 2023-10-30 11:58, Imre Deak wrote: > From: Ville Syrjälä > > The current code does '(bpp << 4) / 16' in the MST PBN > calculation, but that is just the same as 'bpp' so the > DSC codepath achieves absolutely nothing. Fix it up so that > the fractional part of the bpp value is actually used

Re: [Intel-gfx] [PATCH v4 02/30] drm/dp_mst: Fix fractional DSC bpp handling

2023-11-07 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2023-10-30 at 17:58 +0200, Imre Deak wrote: > From: Ville Syrjälä > > The current code does '(bpp << 4) / 16' in the MST PBN > calculation, but that is just the same as 'bpp' so the > DSC codepath achieves absolutely nothing. Fix it up so that > the fractional pa

Re: [Intel-gfx] [PATCH v4 02/30] drm/dp_mst: Fix fractional DSC bpp handling

2023-11-06 Thread Maxime Ripard
On Wed, Nov 01, 2023 at 02:59:50PM +0200, Jani Nikula wrote: > On Tue, 31 Oct 2023, Imre Deak wrote: > > On Mon, Oct 30, 2023 at 05:58:15PM +0200, Imre Deak wrote: > > Hi Lyude, AMD folks et al, > > > > could you ack patches 2-9 in this patchset if they are ok and it's ok to > > merge them via the

Re: [Intel-gfx] [PATCH v4 02/30] drm/dp_mst: Fix fractional DSC bpp handling

2023-11-01 Thread Jani Nikula
On Tue, 31 Oct 2023, Imre Deak wrote: > On Mon, Oct 30, 2023 at 05:58:15PM +0200, Imre Deak wrote: > Hi Lyude, AMD folks et al, > > could you ack patches 2-9 in this patchset if they are ok and it's ok to > merge them via the i915 tree? Need acks from drm-misc maintainers too! Cc: Maxime, Thomas

Re: [Intel-gfx] [PATCH v4 02/30] drm/dp_mst: Fix fractional DSC bpp handling

2023-10-31 Thread Imre Deak
On Mon, Oct 30, 2023 at 05:58:15PM +0200, Imre Deak wrote: Hi Lyude, AMD folks et al, could you ack patches 2-9 in this patchset if they are ok and it's ok to merge them via the i915 tree? Thanks, Imre > From: Ville Syrjälä > > The current code does '(bpp << 4) / 16' in the MST PBN > calculati

[Intel-gfx] [PATCH v4 02/30] drm/dp_mst: Fix fractional DSC bpp handling

2023-10-30 Thread Imre Deak
From: Ville Syrjälä The current code does '(bpp << 4) / 16' in the MST PBN calculation, but that is just the same as 'bpp' so the DSC codepath achieves absolutely nothing. Fix it up so that the fractional part of the bpp value is actually used instead of truncated away. 64*1006 has enough zero ls