Re: [Intel-gfx] [PATCH v4 01/18] drm/sched: Split drm_sched_job_init

2021-07-13 Thread Christian König
Am 12.07.21 um 19:53 schrieb Daniel Vetter: This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is tha

Re: [Intel-gfx] [PATCH v4 01/18] drm/sched: Split drm_sched_job_init

2021-07-12 Thread Daniel Vetter
On Tue, Jul 13, 2021 at 8:40 AM Christian König wrote: > > Am 12.07.21 um 19:53 schrieb Daniel Vetter: > > This is a very confusingly named function, because not just does it > > init an object, it arms it and provides a point of no return for > > pushing a job into the scheduler. It would be nice

Re: [Intel-gfx] [PATCH v4 01/18] drm/sched: Split drm_sched_job_init

2021-07-12 Thread Emma Anholt
On Mon, Jul 12, 2021 at 1:01 PM Daniel Vetter wrote: > > This is a very confusingly named function, because not just does it > init an object, it arms it and provides a point of no return for > pushing a job into the scheduler. It would be nice if that's a bit > clearer in the interface. > > But t

[Intel-gfx] [PATCH v4 01/18] drm/sched: Split drm_sched_job_init

2021-07-12 Thread Daniel Vetter
This is a very confusingly named function, because not just does it init an object, it arms it and provides a point of no return for pushing a job into the scheduler. It would be nice if that's a bit clearer in the interface. But the real reason is that I want to push the dependency tracking helpe