Re: [Intel-gfx] [PATCH v4] drm/i915: rc6 in sysfs

2012-04-11 Thread Daniel Vetter
On Wed, Apr 11, 2012 at 11:10:05PM +0100, Chris Wilson wrote: > On Wed, 11 Apr 2012 09:14:43 +0100, Chris Wilson > wrote: > > I'm down to just bikeshedding over useless lines of code which do not > > even add visual clarity... > > > > Reviewed-by: Chris Wilson > > Oops, need to learn to spot 6

Re: [Intel-gfx] [PATCH v4] drm/i915: rc6 in sysfs

2012-04-11 Thread Chris Wilson
On Wed, 11 Apr 2012 09:14:43 +0100, Chris Wilson wrote: > I'm down to just bikeshedding over useless lines of code which do not > even add visual clarity... > > Reviewed-by: Chris Wilson Oops, need to learn to spot 64-bit divides which become an issue on 32-bit builds. diff --git a/drivers/gp

Re: [Intel-gfx] [PATCH v4] drm/i915: rc6 in sysfs

2012-04-11 Thread Daniel Vetter
On Wed, Apr 11, 2012 at 09:14:43AM +0100, Chris Wilson wrote: > On Tue, 10 Apr 2012 21:17:01 -0700, Ben Widawsky wrote: > > Merge rc6 information into the power group for our device. Until now the > > i915 driver has not had any sysfs entries (aside from the connector > > stuff enabled by drm core

Re: [Intel-gfx] [PATCH v4] drm/i915: rc6 in sysfs

2012-04-11 Thread Chris Wilson
On Tue, 10 Apr 2012 21:17:01 -0700, Ben Widawsky wrote: > Merge rc6 information into the power group for our device. Until now the > i915 driver has not had any sysfs entries (aside from the connector > stuff enabled by drm core). Since it seems like we're likely to have > more in the future I cre

[Intel-gfx] [PATCH v4] drm/i915: rc6 in sysfs

2012-04-10 Thread Ben Widawsky
Merge rc6 information into the power group for our device. Until now the i915 driver has not had any sysfs entries (aside from the connector stuff enabled by drm core). Since it seems like we're likely to have more in the future I created a new file for sysfs stubs, as well as the rc6 sysfs functio