Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: Pre allocate and late cleanup of cmd buffer

2020-04-16 Thread Manna, Animesh
On 16-04-2020 15:19, Maarten Lankhorst wrote: Hey, Seems we're lacking error handling still when get fails? Hi Maarten, Error handling is taken care by dsb-framework, if _prepare() is failed then dsb->cmd_buf will be null and during dsb-write() mmio-write will be used to program registers.

Re: [Intel-gfx] [PATCH v4] drm/i915/dsb: Pre allocate and late cleanup of cmd buffer

2020-04-16 Thread Maarten Lankhorst
Hey, Seems we're lacking error handling still when get fails? ~Maarten Op 13-04-2020 om 08:34 schreef Animesh Manna: > Pre-allocate command buffer in atomic_commit using intel_dsb_prepare > function which also includes pinning and map in cpu domain. > > No change is dsb write/commit functions. >

[Intel-gfx] [PATCH v4] drm/i915/dsb: Pre allocate and late cleanup of cmd buffer

2020-04-12 Thread Animesh Manna
Pre-allocate command buffer in atomic_commit using intel_dsb_prepare function which also includes pinning and map in cpu domain. No change is dsb write/commit functions. Now dsb get/put function is refactored and currently used only for reference counting. Below dsb api added to do respective job