Re: [Intel-gfx] [PATCH v3 11/16] drm/i915/guc: Replace check for golden context size

2022-02-18 Thread Matthew Brost
On Wed, Feb 16, 2022 at 09:41:42AM -0800, Lucas De Marchi wrote: > In the other places in this function, guc->ads_map is being protected > from access when it's not yet set. However the last check is actually > about guc->ads_golden_ctxt_size been set before. These checks should > always match as

[Intel-gfx] [PATCH v3 11/16] drm/i915/guc: Replace check for golden context size

2022-02-16 Thread Lucas De Marchi
In the other places in this function, guc->ads_map is being protected from access when it's not yet set. However the last check is actually about guc->ads_golden_ctxt_size been set before. These checks should always match as the size is initialized on the first call to guc_prep_golden_context(), b