Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gtt: Do not initialize drm_mm twice.

2015-09-24 Thread Winiarski, Michal
On Wed, 2015-09-23 at 15:55 -0300, Paulo Zanoni wrote: > 2015-09-23 13:48 GMT-03:00 Imre Deak : > > On ke, 2015-09-16 at 11:49 +0200, Michał Winiarski wrote: > > > It would be initialized just moments later by i915_init_vm. > > > > > > v2: Commit msg update, > > > s/i915_init_vm/i915_address_s

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gtt: Do not initialize drm_mm twice.

2015-09-23 Thread Jesse Barnes
On 09/23/2015 11:55 AM, Paulo Zanoni wrote: > 2015-09-23 13:48 GMT-03:00 Imre Deak : >> On ke, 2015-09-16 at 11:49 +0200, Michał Winiarski wrote: >>> It would be initialized just moments later by i915_init_vm. >>> >>> v2: Commit msg update, >>> s/i915_init_vm/i915_address_space_init, move to i9

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gtt: Do not initialize drm_mm twice.

2015-09-23 Thread Paulo Zanoni
2015-09-23 13:48 GMT-03:00 Imre Deak : > On ke, 2015-09-16 at 11:49 +0200, Michał Winiarski wrote: >> It would be initialized just moments later by i915_init_vm. >> >> v2: Commit msg update, >> s/i915_init_vm/i915_address_space_init, move to i915_gem_gtt.c, >> init address_space during i915

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gtt: Do not initialize drm_mm twice.

2015-09-23 Thread Imre Deak
On ke, 2015-09-16 at 11:49 +0200, Michał Winiarski wrote: > It would be initialized just moments later by i915_init_vm. > > v2: Commit msg update, > s/i915_init_vm/i915_address_space_init, move to i915_gem_gtt.c, > init address_space during i915_gem_setup_global_gtt for ggtt. > v3: Do not

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gtt: Do not initialize drm_mm twice.

2015-09-23 Thread Daniel Vetter
On Thu, Sep 17, 2015 at 11:59:19AM +0100, Chris Wilson wrote: > On Wed, Sep 16, 2015 at 11:49:00AM +0200, Michał Winiarski wrote: > > Rearrange the code such that i915_init_vm() is next to its callers > inside i915_gem_gtt (and so we can make it static). After removing the > dance around the files

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/gtt: Do not initialize drm_mm twice.

2015-09-17 Thread Chris Wilson
On Wed, Sep 16, 2015 at 11:49:00AM +0200, Michał Winiarski wrote: Rearrange the code such that i915_init_vm() is next to its callers inside i915_gem_gtt (and so we can make it static). After removing the dance around the files, it is clear that we are repeating some work inside the initializers (s

[Intel-gfx] [PATCH v3 1/2] drm/i915/gtt: Do not initialize drm_mm twice.

2015-09-16 Thread Michał Winiarski
It would be initialized just moments later by i915_init_vm. v2: Commit msg update, s/i915_init_vm/i915_address_space_init, move to i915_gem_gtt.c, init address_space during i915_gem_setup_global_gtt for ggtt. v3: Do not init global_link - we are adding it to vm_list moments later, make