Re: [Intel-gfx] [PATCH v3 06/19] drm/i915: Split skl_update_scaler, v3.

2015-06-17 Thread Daniel Vetter
On Thu, Jun 18, 2015 at 07:42:10AM +0200, Maarten Lankhorst wrote: > Op 18-06-15 om 03:48 schreef Matt Roper: > > On Mon, Jun 15, 2015 at 12:33:43PM +0200, Maarten Lankhorst wrote: > >> It's easier to read separate functions for crtc and plane scaler state. > >> > >> Changes since v1: > >> - Updat

Re: [Intel-gfx] [PATCH v3 06/19] drm/i915: Split skl_update_scaler, v3.

2015-06-17 Thread Maarten Lankhorst
Op 18-06-15 om 03:48 schreef Matt Roper: > On Mon, Jun 15, 2015 at 12:33:43PM +0200, Maarten Lankhorst wrote: >> It's easier to read separate functions for crtc and plane scaler state. >> >> Changes since v1: >> - Update documentation. >> Changes since v2: >> - Get rid of parameters to skl_update

Re: [Intel-gfx] [PATCH v3 06/19] drm/i915: Split skl_update_scaler, v3.

2015-06-17 Thread Matt Roper
On Mon, Jun 15, 2015 at 12:33:43PM +0200, Maarten Lankhorst wrote: > It's easier to read separate functions for crtc and plane scaler state. > > Changes since v1: > - Update documentation. > Changes since v2: > - Get rid of parameters to skl_update_scaler only used for traces. >This avoids n

[Intel-gfx] [PATCH v3 06/19] drm/i915: Split skl_update_scaler, v3.

2015-06-15 Thread Maarten Lankhorst
It's easier to read separate functions for crtc and plane scaler state. Changes since v1: - Update documentation. Changes since v2: - Get rid of parameters to skl_update_scaler only used for traces. This avoids needing to document the other parameters. Signed-off-by: Maarten Lankhorst ---