Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Christian König
Am 09.07.21 um 10:00 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 9:23 AM Christian König wrote: Am 09.07.21 um 09:14 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 8:53 AM Christian König wrote: Am 08.07.21 um 19:37 schrieb Daniel Vetter: If it does, someone managed to set up a sched_entit

Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Christian König
Am 09.07.21 um 09:14 schrieb Daniel Vetter: On Fri, Jul 9, 2021 at 8:53 AM Christian König wrote: Am 08.07.21 um 19:37 schrieb Daniel Vetter: If it does, someone managed to set up a sched_entity without schedulers, which is just a driver bug. NAK, it is perfectly valid for rq selection to fai

Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Christian König
Am 08.07.21 um 19:37 schrieb Daniel Vetter: If it does, someone managed to set up a sched_entity without schedulers, which is just a driver bug. NAK, it is perfectly valid for rq selection to fail. See drm_sched_pick_best():     if (!sched->ready) {     DRM_WAR

Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 9:23 AM Christian König wrote: > Am 09.07.21 um 09:14 schrieb Daniel Vetter: > > On Fri, Jul 9, 2021 at 8:53 AM Christian König > > wrote: > >> Am 08.07.21 um 19:37 schrieb Daniel Vetter: > >>> If it does, someone managed to set up a sched_entity without > >>> schedulers,

Re: [Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 8:53 AM Christian König wrote: > Am 08.07.21 um 19:37 schrieb Daniel Vetter: > > If it does, someone managed to set up a sched_entity without > > schedulers, which is just a driver bug. > > NAK, it is perfectly valid for rq selection to fail. There isn't a better way to exp

[Intel-gfx] [PATCH v3 01/20] drm/sched: entity->rq selection cannot fail

2021-07-08 Thread Daniel Vetter
If it does, someone managed to set up a sched_entity without schedulers, which is just a driver bug. We BUG_ON() here because in the next patch drm_sched_job_init() will be split up, with drm_sched_job_arm() never failing. And that's the part where the rq selection will end up in. Note that if ha