Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-22 Thread Dave Gordon
On 22/07/16 13:51, Tvrtko Ursulin wrote: On 22/07/16 13:42, Dave Gordon wrote: On 21/07/16 14:46, Tvrtko Ursulin wrote: On 21/07/16 14:31, Chris Wilson wrote: On Thu, Jul 21, 2016 at 02:16:22PM +0100, Tvrtko Ursulin wrote: On 21/07/16 13:59, Chris Wilson wrote: On Thu, Jul 21, 2016 at 01:0

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-22 Thread Tvrtko Ursulin
On 22/07/16 13:42, Dave Gordon wrote: On 21/07/16 14:46, Tvrtko Ursulin wrote: On 21/07/16 14:31, Chris Wilson wrote: On Thu, Jul 21, 2016 at 02:16:22PM +0100, Tvrtko Ursulin wrote: On 21/07/16 13:59, Chris Wilson wrote: On Thu, Jul 21, 2016 at 01:00:47PM +0100, Tvrtko Ursulin wrote: From:

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-22 Thread Dave Gordon
On 21/07/16 14:46, Tvrtko Ursulin wrote: On 21/07/16 14:31, Chris Wilson wrote: On Thu, Jul 21, 2016 at 02:16:22PM +0100, Tvrtko Ursulin wrote: On 21/07/16 13:59, Chris Wilson wrote: On Thu, Jul 21, 2016 at 01:00:47PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Static table wastes s

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-21 Thread Chris Wilson
On Thu, Jul 21, 2016 at 02:46:01PM +0100, Tvrtko Ursulin wrote: > > On 21/07/16 14:31, Chris Wilson wrote: > >Hmm. This was in intel_ringbuffer.c, at least I assumed so as this only > >applies to legacy submission, for gen6-7. > > It uses the static intel_engines array since the dev_priv->engines

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-21 Thread Tvrtko Ursulin
On 21/07/16 14:31, Chris Wilson wrote: On Thu, Jul 21, 2016 at 02:16:22PM +0100, Tvrtko Ursulin wrote: On 21/07/16 13:59, Chris Wilson wrote: On Thu, Jul 21, 2016 at 01:00:47PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Static table wastes space for invalid combinations and engines

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-21 Thread Chris Wilson
On Thu, Jul 21, 2016 at 02:16:22PM +0100, Tvrtko Ursulin wrote: > > On 21/07/16 13:59, Chris Wilson wrote: > >On Thu, Jul 21, 2016 at 01:00:47PM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Static table wastes space for invalid combinations and > >>engines which are not supporte

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-21 Thread Tvrtko Ursulin
On 21/07/16 14:16, Tvrtko Ursulin wrote: [snip] +{ +if (x == y) +return -1; + +x = intel_engines[x].guc_id; +y = intel_engines[y].guc_id; hw_id. Some guys named Chris and Dave removed it. ;D I need to take this back, I was confusing two tables and some past discussio

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-21 Thread Tvrtko Ursulin
On 21/07/16 13:59, Chris Wilson wrote: On Thu, Jul 21, 2016 at 01:00:47PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Static table wastes space for invalid combinations and engines which are not supported by Gen6 (legacy semaphores). Replace it with a function devised by Dave Gordon.

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-21 Thread Chris Wilson
On Thu, Jul 21, 2016 at 01:00:47PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Static table wastes space for invalid combinations and > engines which are not supported by Gen6 (legacy semaphores). > > Replace it with a function devised by Dave Gordon. > > I have verified that it gen

[Intel-gfx] [PATCH v3] drm/i915: Replace gen6 semaphore signal table with code

2016-07-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Static table wastes space for invalid combinations and engines which are not supported by Gen6 (legacy semaphores). Replace it with a function devised by Dave Gordon. I have verified that it generates the same mappings between mbox selectors and signalling registers. v2: A