Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-23 18:25:55) > Knowing that GuC will be reset soon, we may stop all communication > immediately without doing graceful cleanup as it is not needed. > > This patch will also help us capture any unwanted/unexpected attempts > to talk with GuC after we decided to res

[Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Michal Wajdeczko
Knowing that GuC will be reset soon, we may stop all communication immediately without doing graceful cleanup as it is not needed. This patch will also help us capture any unwanted/unexpected attempts to talk with GuC after we decided to reset it. And we need to keep 'disable' part as current and

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-23 16:53:27) > On Wed, 22 May 2019 22:06:53 +0200, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-05-22 20:32:02) > >> Knowing that GuC will be reset soon, we may stop all communication > >> immediately without doing graceful cleanup as it is not ne

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-23 Thread Michal Wajdeczko
On Wed, 22 May 2019 22:06:53 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-05-22 20:32:02) Knowing that GuC will be reset soon, we may stop all communication immediately without doing graceful cleanup as it is not needed. The difference between stop and disable is that it avoid

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-22 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-22 20:32:02) > Knowing that GuC will be reset soon, we may stop all communication > immediately without doing graceful cleanup as it is not needed. The difference between stop and disable is that it avoids the serialisation, right? Is this patch still required --

[Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

2019-05-22 Thread Michal Wajdeczko
Knowing that GuC will be reset soon, we may stop all communication immediately without doing graceful cleanup as it is not needed. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/intel_guc_ct.h | 5 + drivers/gpu/drm/i915/intel_uc.c