Re: [Intel-gfx] [PATCH v2 4/7] drm/i915: Agressive downclocking on Baytrail

2015-03-18 Thread Deepak S
On Wednesday 18 March 2015 04:53 PM, Chris Wilson wrote: On Wed, Mar 18, 2015 at 04:45:08PM +0530, Deepak S wrote: + if (val != dev_priv->rps.cur_freq) { vlv_punit_write(dev_priv, PUNIT_REG_GPU_FREQ_REQ, val); + gen6_set_rps_thresholds(dev_priv, val); I thi

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915: Agressive downclocking on Baytrail

2015-03-18 Thread Chris Wilson
On Wed, Mar 18, 2015 at 04:45:08PM +0530, Deepak S wrote: > >+if (val != dev_priv->rps.cur_freq) { > > vlv_punit_write(dev_priv, PUNIT_REG_GPU_FREQ_REQ, val); > >+gen6_set_rps_thresholds(dev_priv, val); > > I think gen6_set_rps_thresholds should be under baytrail specif

Re: [Intel-gfx] [PATCH v2 4/7] drm/i915: Agressive downclocking on Baytrail

2015-03-18 Thread Deepak S
On Wednesday 18 March 2015 03:18 PM, Chris Wilson wrote: Reuse the same reclocking strategy for Baytail as on its bigger brethren, Sandybridge and Ivybridge. In particular, this makes the device quicker to reclock (both up and down) though the tendency now is to downclock more aggressively to c

[Intel-gfx] [PATCH v2 4/7] drm/i915: Agressive downclocking on Baytrail

2015-03-18 Thread Chris Wilson
Reuse the same reclocking strategy for Baytail as on its bigger brethren, Sandybridge and Ivybridge. In particular, this makes the device quicker to reclock (both up and down) though the tendency now is to downclock more aggressively to compensate for the RPS boosts. v2: Rebase Signed-off-by: Chr