Re: [Intel-gfx] [PATCH v2 3/9] vfio/ccw: Convert to use vfio_register_group_dev()

2021-09-27 Thread Jason Gunthorpe
On Fri, Sep 24, 2021 at 04:37:43PM -0400, Eric Farman wrote: > > @@ -528,6 +534,7 @@ static int __init vfio_ccw_sch_init(void) > > > > static void __exit vfio_ccw_sch_exit(void) > > { > > + mdev_unregister_driver(&vfio_ccw_mdev_driver); > > Wouldn't it be better to mirror the unwind-init cas

Re: [Intel-gfx] [PATCH v2 3/9] vfio/ccw: Convert to use vfio_register_group_dev()

2021-09-24 Thread Eric Farman
On Thu, 2021-09-09 at 16:38 -0300, Jason Gunthorpe wrote: > This is a more complicated conversion because vfio_ccw is sharing the > vfio_device between both the mdev_device, its vfio_device and the > css_driver. > > The mdev is a singleton, and the reason for this sharing is so the > extra > css_d

[Intel-gfx] [PATCH v2 3/9] vfio/ccw: Convert to use vfio_register_group_dev()

2021-09-09 Thread Jason Gunthorpe
This is a more complicated conversion because vfio_ccw is sharing the vfio_device between both the mdev_device, its vfio_device and the css_driver. The mdev is a singleton, and the reason for this sharing is so the extra css_driver function callbacks to be delivered to the vfio_device implementati