Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 7:38 PM, Ville Syrjälä wrote: > We have the same problem already w/ underrun interrupts at least, no? Yeah, but iirc we've hand-waved over the issue with "hopefully the bios wm setup never underruns while we take over". If it does we're screwed ;-) Wrt vblank interrupts I

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Ville Syrjälä
On Mon, Jan 20, 2014 at 06:43:42PM +0100, Daniel Vetter wrote: > On Mon, Jan 20, 2014 at 5:56 PM, Ville Syrjälä > wrote: > >> > +{ > >> > + struct drm_device *dev = crtc->dev; > >> > + struct intel_crtc *intel_crtc = to_intel_crtc(crtc); > >> > + const struct drm_display_mode *mode = > >> >

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 5:56 PM, Ville Syrjälä wrote: >> > +{ >> > + struct drm_device *dev = crtc->dev; >> > + struct intel_crtc *intel_crtc = to_intel_crtc(crtc); >> > + const struct drm_display_mode *mode = >> > &intel_crtc->config.adjusted_mode; >> > + enum pipe pipe = intel_crtc->pip

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Ville Syrjälä
On Mon, Jan 20, 2014 at 05:23:39PM +0100, Daniel Vetter wrote: > On Fri, Jan 17, 2014 at 08:09:04PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Add a mechanism by which we can evade the leading edge of vblank. This > > guarantees that no two sprite register writes

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-20 Thread Daniel Vetter
On Fri, Jan 17, 2014 at 08:09:04PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Add a mechanism by which we can evade the leading edge of vblank. This > guarantees that no two sprite register writes will straddle on either > side of the vblank start, and that means all th

[Intel-gfx] [PATCH v2 3/5] drm/i915: Make sprite updates atomic

2014-01-17 Thread ville . syrjala
From: Ville Syrjälä Add a mechanism by which we can evade the leading edge of vblank. This guarantees that no two sprite register writes will straddle on either side of the vblank start, and that means all the writes will be latched together in one atomic operation. We do the vblank evade by che