Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-04-15 Thread Ville Syrjälä
On Tue, Apr 15, 2014 at 04:53:22PM +0530, Sagar Arun Kamble wrote: > Hi Ville, > > Thanks for the reply. > I have few more queries. > On Tue, 2014-04-15 at 13:35 +0300, Ville Syrjälä wrote: > > On Tue, Apr 15, 2014 at 03:14:04PM +0530, Sagar Arun Kamble wrote: > > > Hi Ville, > > > > > > Somehow

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-04-15 Thread Sagar Arun Kamble
Hi Ville, Thanks for the reply. I have few more queries. On Tue, 2014-04-15 at 13:35 +0300, Ville Syrjälä wrote: > On Tue, Apr 15, 2014 at 03:14:04PM +0530, Sagar Arun Kamble wrote: > > Hi Ville, > > > > Somehow I did not receive your review comments > > (http://lists.freedesktop.org/archives/int

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-04-15 Thread Ville Syrjälä
On Tue, Apr 15, 2014 at 03:14:04PM +0530, Sagar Arun Kamble wrote: > Hi Ville, > > Somehow I did not receive your review comments > (http://lists.freedesktop.org/archives/intel-gfx/2014-April/042956.html > ) in my mailbox. > > Here is my input w.r.t patches I have sent for review: > > Currently

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-04-15 Thread Sagar Arun Kamble
Hi Ville, Somehow I did not receive your review comments (http://lists.freedesktop.org/archives/intel-gfx/2014-April/042956.html ) in my mailbox. Here is my input w.r.t patches I have sent for review: Currently my patches are modeling constant alpha blend factor (assuming pre-multiplied format)

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-04-02 Thread Sagar Arun Kamble
Hi Ville, Could you please review these patches. thanks, Sagar On Wed, 2014-04-02 at 11:42 +0530, Sagar Arun Kamble wrote: > Reminder for review :) > > On Tue, 2014-04-01 at 10:21 +0530, Sagar Arun Kamble wrote: > > Gentle Reminder for reviewing this and related patches: > > http://lists.freed

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-04-01 Thread Sagar Arun Kamble
Reminder for review :) On Tue, 2014-04-01 at 10:21 +0530, Sagar Arun Kamble wrote: > Gentle Reminder for reviewing this and related patches: > http://lists.freedesktop.org/archives/intel-gfx/2014-March/042350.html > http://lists.freedesktop.org/archives/intel-gfx/2014-March/042351.html > http://li

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-03-31 Thread Sagar Arun Kamble
Gentle Reminder for reviewing this and related patches: http://lists.freedesktop.org/archives/intel-gfx/2014-March/042350.html http://lists.freedesktop.org/archives/intel-gfx/2014-March/042351.html http://lists.freedesktop.org/archives/intel-gfx/2014-March/042352.html http://lists.freedesktop.org/a

[Intel-gfx] [PATCH v2 3/4] drm/i915: Enabling constant alpha drm property

2014-03-25 Thread sagar . a . kamble
From: Sagar Kamble This patch enables constant alpha property for Sprite planes. Client has to set BIT(DRM_BLEND_CONSTANT_ALPHA) | ((alpha value) << 32) for applying constant alpha on a plane. To disable constant alpha, client has to set BIT(DRM_BLEND_SRC_COLOR) v2: Fixing property value compari