Re: [Intel-gfx] [PATCH v2 20/21] drm/i915: Check for unpin correctness.

2016-05-19 Thread Patrik Jakobsson
On Tue, May 17, 2016 at 03:08:03PM +0200, Maarten Lankhorst wrote: > If planes are added to the state after the call to > drm_atomic_helper_check_planes planes_changed may not be set > and we will not unpin the old framebuffer. This results in a > pin leak long after the framebuffer is destroyed, s

[Intel-gfx] [PATCH v2 20/21] drm/i915: Check for unpin correctness.

2016-05-17 Thread Maarten Lankhorst
If planes are added to the state after the call to drm_atomic_helper_check_planes planes_changed may not be set and we will not unpin the old framebuffer. This results in a pin leak long after the framebuffer is destroyed, so to find this add some checks when it happens. Signed-off-by: Maarten Lan