Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: Cache last cmd descriptor when parsing

2015-12-01 Thread Ville Syrjälä
On Fri, Nov 20, 2015 at 10:55:57AM +, Chris Wilson wrote: > The cmd parser has the biggest impact on the BLT ring, because it is > relatively verbose composed to the other engines as the vertex data is > inline. It also typically has runs of repeating commands (again since > the vertex data is

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: Cache last cmd descriptor when parsing

2015-11-20 Thread Chris Wilson
On Fri, Nov 20, 2015 at 05:08:06PM +0200, Ville Syrjälä wrote: > On Fri, Nov 20, 2015 at 10:55:57AM +, Chris Wilson wrote: > > + desc = find_cmd_in_table(ring, *cmd); > > + if (desc) { > > + if (unlikely(desc-

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: Cache last cmd descriptor when parsing

2015-11-20 Thread Ville Syrjälä
On Fri, Nov 20, 2015 at 10:55:57AM +, Chris Wilson wrote: > The cmd parser has the biggest impact on the BLT ring, because it is > relatively verbose composed to the other engines as the vertex data is > inline. It also typically has runs of repeating commands (again since > the vertex data is

[Intel-gfx] [PATCH v2 2/6] drm/i915: Cache last cmd descriptor when parsing

2015-11-20 Thread Chris Wilson
The cmd parser has the biggest impact on the BLT ring, because it is relatively verbose composed to the other engines as the vertex data is inline. It also typically has runs of repeating commands (again since the vertex data is inline, it typically has sequences of XY_SETUP_BLT, XY_SCANLINE_BLT..)