Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-26 Thread Ville Syrjälä
On Wed, Apr 25, 2018 at 02:57:57PM -0700, Dhinakaran Pandiyan wrote: > Sink crc is calculated by the sink for static frames irrespective of > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only use > case for sink crc, we don't really need the sink_crc_{start, stop} code. > > The s

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-25 Thread Rodrigo Vivi
On Wed, Apr 25, 2018 at 02:57:57PM -0700, Dhinakaran Pandiyan wrote: > Sink crc is calculated by the sink for static frames irrespective of > what the driver sets in TEST_SINK_START dpcd. Since PSR is the only use > case for sink crc, we don't really need the sink_crc_{start, stop} code. > > The s

[Intel-gfx] [PATCH v2 2/3] drm/i915/dp: Fix sink-crc reads.

2018-04-25 Thread Dhinakaran Pandiyan
Sink crc is calculated by the sink for static frames irrespective of what the driver sets in TEST_SINK_START dpcd. Since PSR is the only use case for sink crc, we don't really need the sink_crc_{start, stop} code. The second problem with the current implementation is vblank waits. Enabling vblank