Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Change values for i915_guc_log_control

2018-01-21 Thread Sagar Arun Kamble
On 1/18/2018 11:26 PM, Chris Wilson wrote: Quoting Chris Wilson (2018-01-18 17:21:57) Quoting Sagar Arun Kamble (2018-01-12 05:53:28) On 1/11/2018 8:54 PM, Michal Wajdeczko wrote: Today we have format mismatch between read/write operations of i915_guc_log_control entry. For read we return (

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Change values for i915_guc_log_control

2018-01-18 Thread Chris Wilson
Quoting Chris Wilson (2018-01-18 17:21:57) > Quoting Sagar Arun Kamble (2018-01-12 05:53:28) > > > > > > On 1/11/2018 8:54 PM, Michal Wajdeczko wrote: > > > Today we have format mismatch between read/write operations > > > of i915_guc_log_control entry. For read we return (0, 1..4) > > > that rep

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Change values for i915_guc_log_control

2018-01-18 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-01-12 05:53:28) > > > On 1/11/2018 8:54 PM, Michal Wajdeczko wrote: > > Today we have format mismatch between read/write operations > > of i915_guc_log_control entry. For read we return (0, 1..4) > > that represents disable/verbosity levels, but for write we > > fo

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Change values for i915_guc_log_control

2018-01-11 Thread Sagar Arun Kamble
On 1/11/2018 8:54 PM, Michal Wajdeczko wrote: Today we have format mismatch between read/write operations of i915_guc_log_control entry. For read we return (0, 1..4) that represents disable/verbosity levels, but for write we force user to follow internal structure format (0,1,9,11,13). 0x0, 0x

[Intel-gfx] [PATCH v2 2/2] drm/i915/guc: Change values for i915_guc_log_control

2018-01-11 Thread Michal Wajdeczko
Today we have format mismatch between read/write operations of i915_guc_log_control entry. For read we return (0, 1..4) that represents disable/verbosity levels, but for write we force user to follow internal structure format (0,1,9,11,13). Let's hide internals from the user and accept same values