Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: only allow WB for smem only placements

2021-06-28 Thread Thomas Hellström
On 6/28/21 12:20 PM, Matthew Auld wrote: On 28/06/2021 10:38, Thomas Hellström wrote: Hi, On 6/28/21 11:12 AM, Matthew Auld wrote: On 28/06/2021 08:41, Thomas Hellström wrote: On 6/25/21 2:27 PM, Matthew Auld wrote: We only support single mode and this should be immutable. For smem only p

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: only allow WB for smem only placements

2021-06-28 Thread Matthew Auld
On 28/06/2021 10:38, Thomas Hellström wrote: Hi, On 6/28/21 11:12 AM, Matthew Auld wrote: On 28/06/2021 08:41, Thomas Hellström wrote: On 6/25/21 2:27 PM, Matthew Auld wrote: We only support single mode and this should be immutable. For smem only placements on DGFX this should be WB. On DG1

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: only allow WB for smem only placements

2021-06-28 Thread Thomas Hellström
Hi, On 6/28/21 11:12 AM, Matthew Auld wrote: On 28/06/2021 08:41, Thomas Hellström wrote: On 6/25/21 2:27 PM, Matthew Auld wrote: We only support single mode and this should be immutable. For smem only placements on DGFX this should be WB. On DG1 everything is snooped, always, and so should b

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: only allow WB for smem only placements

2021-06-28 Thread Matthew Auld
On 28/06/2021 08:41, Thomas Hellström wrote: On 6/25/21 2:27 PM, Matthew Auld wrote: We only support single mode and this should be immutable. For smem only placements on DGFX this should be WB. On DG1 everything is snooped, always, and so should be coherent. I915_GEM_DOMAIN_GTT looks like it'

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/gem: only allow WB for smem only placements

2021-06-28 Thread Thomas Hellström
On 6/25/21 2:27 PM, Matthew Auld wrote: We only support single mode and this should be immutable. For smem only placements on DGFX this should be WB. On DG1 everything is snooped, always, and so should be coherent. I915_GEM_DOMAIN_GTT looks like it's for the aperture which is now gone for DGFX,

[Intel-gfx] [PATCH v2 2/2] drm/i915/gem: only allow WB for smem only placements

2021-06-25 Thread Matthew Auld
We only support single mode and this should be immutable. For smem only placements on DGFX this should be WB. On DG1 everything is snooped, always, and so should be coherent. I915_GEM_DOMAIN_GTT looks like it's for the aperture which is now gone for DGFX, so hopefully can also be safely rejected.