Re: [Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-09-06 Thread Manasi Navare
Few more comments here regarding the fixes required for fixing all the seen corruption. I have made these fixes and will add themin the next revision submission. On Wed, Sep 05, 2018 at 01:33:35PM -0700, Manasi Navare wrote: > One more fix below which was the cause of all the artifacts > > On We

Re: [Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-09-05 Thread Manasi Navare
One more fix below which was the cause of all the artifacts On Wed, Sep 05, 2018 at 01:04:48PM -0700, Manasi Navare wrote: > Gaurav, > > Please find my review comments below. Caught them when I tested > your patch on DSC sink. > > On Tue, Jul 31, 2018 at 02:07:11PM -0700, Manasi Navare wrote: >

Re: [Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-09-05 Thread Manasi Navare
Gaurav, Please find my review comments below. Caught them when I tested your patch on DSC sink. On Tue, Jul 31, 2018 at 02:07:11PM -0700, Manasi Navare wrote: > From: Gaurav K Singh > > This patches does the following: > > 1. This patch defines all the DSC parameters as per the VESA > DSC spec

Re: [Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-08-28 Thread Manasi Navare
On Tue, Aug 28, 2018 at 03:47:21PM -0700, Manasi Navare wrote: > On Tue, Aug 28, 2018 at 03:18:56PM -0700, Srivatsa, Anusha wrote: > > > > > > >-Original Message- > > >From: Navare, Manasi D > > >Sent: Tuesday, July 31, 2018 2:07 PM > > >To: intel-gfx@lists.freedesktop.org > > >Cc: Singh,

Re: [Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-08-28 Thread Manasi Navare
On Tue, Aug 28, 2018 at 03:18:56PM -0700, Srivatsa, Anusha wrote: > > > >-Original Message- > >From: Navare, Manasi D > >Sent: Tuesday, July 31, 2018 2:07 PM > >To: intel-gfx@lists.freedesktop.org > >Cc: Singh, Gaurav K ; Jani Nikula > >; Ville Syrjala ; > >Srivatsa, Anusha ; Navare, Mana

Re: [Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-08-28 Thread Srivatsa, Anusha
>-Original Message- >From: Navare, Manasi D >Sent: Tuesday, July 31, 2018 2:07 PM >To: intel-gfx@lists.freedesktop.org >Cc: Singh, Gaurav K ; Jani Nikula >; Ville Syrjala ; >Srivatsa, Anusha ; Navare, Manasi D > >Subject: [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params > >

[Intel-gfx] [PATCH v2 15/23] drm/i915/dsc: Define & Compute VESA DSC params

2018-07-31 Thread Manasi Navare
From: Gaurav K Singh This patches does the following: 1. This patch defines all the DSC parameters as per the VESA DSC specification. These are stored in the encoder and used to compute the PPS parameters to be sent to the Sink. 2. Compute all the DSC parameters which are derived from DSC state