> -Original Message-
> From: Jani Nikula
> Sent: Thursday, January 14, 2021 2:16 PM
> To: Gupta, Anshuman
> Cc: intel-gfx@lists.freedesktop.org; ville.syrj...@linux.intel.com
> Subject: Re: [PATCH v2 14/17] drm/i915/pps: refactor init abstractions
>
> On Wed, 13 Jan 2021, Anshuman Gup
On Wed, 13 Jan 2021, Anshuman Gupta wrote:
> On 2021-01-08 at 19:44:22 +0200, Jani Nikula wrote:
>> @@ -1366,20 +1352,21 @@ void intel_pps_encoder_reset(struct intel_dp
>> *intel_dp)
>> * Reinit the power sequencer, in case BIOS did something nasty
> IMHO above comment
On 2021-01-08 at 19:44:22 +0200, Jani Nikula wrote:
> Once you realize there is no need to hold the pps mutex when calling
> pps_init_timestamps() in intel_pps_init(), we can reuse
> intel_pps_encoder_reset() which has the same code.
>
> Since intel_dp_pps_init() is only called from one place now,
Once you realize there is no need to hold the pps mutex when calling
pps_init_timestamps() in intel_pps_init(), we can reuse
intel_pps_encoder_reset() which has the same code.
Since intel_dp_pps_init() is only called from one place now, move it
inline to remove one "init" function altogether.
Fin
