Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-12-02 Thread Miguel Ojeda
On Fri, Nov 29, 2019 at 4:24 PM Daniel Vetter wrote: > > Oh, another display subsystem? Intriguing ... > > Reviewed-by: Daniel Vetter It is intended for displays that are not intended as the usual/main display, e.g. very small LCDs :) Reviewed-by: Miguel Ojeda Cheers, Miguel _

Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-12-02 Thread robin
On 2019-11-29 11:29, Jani Nikula wrote: Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: Miguel Ojeda Sandonis Cc: Robin van der Gracht Signed-off-by: Jani Nikula --- drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c

Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-12-02 Thread robin
On 2019-11-29 21:59, Miguel Ojeda wrote: On Fri, Nov 29, 2019 at 9:30 PM Daniel Vetter wrote: Well we do have very small lcd display drivers in drm, and before that in fbdev. And you have a fbdev framebuffer driver in there, which looks a bit misplaced ... Afaiui you also have some even ti

Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-12-02 Thread Miguel Ojeda
On Fri, Nov 29, 2019 at 9:30 PM Daniel Vetter wrote: > > Well we do have very small lcd display drivers in drm, and before that in > fbdev. And you have a fbdev framebuffer driver in there, which looks a bit > misplaced ... > > Afaiui you also have some even tinier lcd drivers where you don't addr

Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-11-29 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 09:16:42PM +0100, Miguel Ojeda wrote: > On Fri, Nov 29, 2019 at 4:24 PM Daniel Vetter wrote: > > > > Oh, another display subsystem? Intriguing ... > > > > Reviewed-by: Daniel Vetter > > It is intended for displays that are not intended as the usual/main > display, e.g. ve

Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-11-29 Thread Daniel Vetter
On Fri, Nov 29, 2019 at 12:29:44PM +0200, Jani Nikula wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > Cc: Miguel Ojeda Sandonis > Cc: Robin van der Gracht > Signed-off-by: Jani Nikula > --- > drivers/auxdisplay/cfag12864bfb.c | 2

[Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops

2019-11-29 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: Miguel Ojeda Sandonis Cc: Robin van der Gracht Signed-off-by: Jani Nikula --- drivers/auxdisplay/cfag12864bfb.c | 2 +- drivers/auxdisplay/ht16k33.c | 2 +- 2 files changed, 2 insertions(+