Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Eliminate vmap overhead for cmd parser

2015-11-20 Thread Chris Wilson
On Fri, Nov 20, 2015 at 04:41:53PM +0200, Ville Syrjälä wrote: > > + if (batch_len > shadow_batch_obj->base.size || > > AFAIK that can't actaully happen since we allocate the shadow batch > based on batch_len. But I see it was already like this in the old code. > > > + batch_len + batch_s

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Eliminate vmap overhead for cmd parser

2015-11-20 Thread Ville Syrjälä
On Fri, Nov 20, 2015 at 10:55:56AM +, Chris Wilson wrote: > With a little complexity to handle cmds straddling page boundaries, we > can completely avoiding having to vmap the batch and the shadow batch > objects whilst running the command parser. > > On ivb i7-3720MQ: > > x11perf -dot before

[Intel-gfx] [PATCH v2 1/6] drm/i915: Eliminate vmap overhead for cmd parser

2015-11-20 Thread Chris Wilson
With a little complexity to handle cmds straddling page boundaries, we can completely avoiding having to vmap the batch and the shadow batch objects whilst running the command parser. On ivb i7-3720MQ: x11perf -dot before 54.3M, after 53.2M (max 203M) glxgears before 7110 fps, after 7300 fps (max